chrome/browser/autofill/autofill_metrics_unittest.cc - Issue 7576001: Refactor webkit_glue::FormField to remove hacky methods

Unified Diff: chrome/browser/autofill/autofill_metrics_unittest.cc

Issue 7576001: Refactor webkit_glue::FormField to remove hacky methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix copyright header Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autofill/autofill_metrics_unittest.cc

diff --git a/chrome/browser/autofill/autofill_metrics_unittest.cc b/chrome/browser/autofill/autofill_metrics_unittest.cc

index f0c4a33a6ddbb28f9d0572a81bb7cba604a88909..95eb844550616229d11bb5e19e8d8133ba0fe1e2 100644

--- a/chrome/browser/autofill/autofill_metrics_unittest.cc

+++ b/chrome/browser/autofill/autofill_metrics_unittest.cc

@@ -271,24 +271,28 @@ TEST_F(AutofillMetricsTest, QualityMetrics) {

autofill_test::CreateTestFormField(

"Autofill Failed", "autofillfailed", "buddy@gmail.com", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(PHONE_HOME_NUMBER);

server_types.push_back(EMAIL_ADDRESS);

autofill_test::CreateTestFormField(

"Empty", "empty", "", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(NAME_FULL);

server_types.push_back(NAME_FIRST);

autofill_test::CreateTestFormField(

"Unknown", "unknown", "garbage", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(PHONE_HOME_NUMBER);

server_types.push_back(EMAIL_ADDRESS);

autofill_test::CreateTestFormField(

"Select", "select", "USA", "select-one", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(UNKNOWN_TYPE);

server_types.push_back(NO_SERVER_DATA);

@@ -529,16 +533,19 @@ TEST_F(AutofillMetricsTest, SaneMetricsWithCacheMismatch) {

server_types.push_back(NAME_FULL);

autofill_test::CreateTestFormField(

"Both mismatch", "mismatch", "buddy@gmail.com", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(PHONE_HOME_NUMBER);

server_types.push_back(PHONE_HOME_NUMBER);

autofill_test::CreateTestFormField(

"Only heuristics match", "mixed", "Memphis", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(ADDRESS_HOME_CITY);

server_types.push_back(PHONE_HOME_NUMBER);

autofill_test::CreateTestFormField(

"Unknown", "unknown", "garbage", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(UNKNOWN_TYPE);

server_types.push_back(UNKNOWN_TYPE);

@@ -721,24 +728,28 @@ TEST_F(AutofillMetricsTest, QualityMetricsWithExperimentId) {

autofill_test::CreateTestFormField(

"Autofill Failed", "autofillfailed", "buddy@gmail.com", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(PHONE_HOME_NUMBER);

server_types.push_back(EMAIL_ADDRESS);

autofill_test::CreateTestFormField(

"Empty", "empty", "", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(NAME_FULL);

server_types.push_back(NAME_FIRST);

autofill_test::CreateTestFormField(

"Unknown", "unknown", "garbage", "text", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(PHONE_HOME_NUMBER);

server_types.push_back(EMAIL_ADDRESS);

autofill_test::CreateTestFormField(

"Select", "select", "USA", "select-one", &field);

+ field.is_autofilled = false;

form.fields.push_back(field);

heuristic_types.push_back(UNKNOWN_TYPE);

server_types.push_back(NO_SERVER_DATA);

« no previous file with comments | « chrome/browser/autofill/autofill_merge_unittest.cc ('k') | chrome/browser/autofill/credit_card_field_unittest.cc » ('j') | no next file with comments »