Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 7554015: Implemented support for GL constext share groups in the renderer process. (Closed)

Created:
9 years, 4 months ago by apatrick_chromium
Modified:
9 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Implemented support for GL context share groups in the renderer process.I put all compositor and canvas contexts in the same share group so they can share IDs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95345

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -118 lines) Patch
M content/common/gpu/gpu_channel.cc View 1 2 2 chunks +16 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/gpu_channel_host.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/gpu_channel_host.cc View 1 2 4 chunks +9 lines, -1 line 0 comments Download
M content/renderer/gpu/renderer_gl_context.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.cc View 1 2 3 9 chunks +24 lines, -39 lines 1 comment Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 7 chunks +21 lines, -0 lines 0 comments Download
M content/renderer/pepper_platform_context_3d_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/common/id_allocator.h View 1 2 3 chunks +47 lines, -9 lines 1 comment Download
M gpu/command_buffer/common/id_allocator.cc View 1 2 2 chunks +33 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 2 2 chunks +11 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 9 chunks +10 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 3 19 chunks +51 lines, -42 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
apatrick_chromium
This isn't ready for review yet; I'm still testing it. If you want to integrate ...
9 years, 4 months ago (2011-08-02 20:47:03 UTC) #1
apatrick_chromium
Ready for review.
9 years, 4 months ago (2011-08-03 21:44:10 UTC) #2
jamesr
9 years, 4 months ago (2011-08-03 21:51:20 UTC) #3
lgtm w/ comments

http://codereview.chromium.org/7554015/diff/16001/content/renderer/gpu/render...
File content/renderer/gpu/renderer_gl_context.cc (right):

http://codereview.chromium.org/7554015/diff/16001/content/renderer/gpu/render...
content/renderer/gpu/renderer_gl_context.cc:204:
parent_->gles2_implementation_->Flush();
why is this doing a flush on the parent? shouldn't it be doing a flush on this
context, since it's really creating a texture here (and not on the parent)?

http://codereview.chromium.org/7554015/diff/16001/gpu/command_buffer/common/i...
File gpu/command_buffer/common/id_allocator.h (right):

http://codereview.chromium.org/7554015/diff/16001/gpu/command_buffer/common/i...
gpu/command_buffer/common/id_allocator.h:76: // implementation does not track
which IDs are currently used. It is usedul for
typo: usedul -> useful

http://codereview.chromium.org/7554015/diff/16001/webkit/gpu/webgraphicsconte...
File webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (right):

http://codereview.chromium.org/7554015/diff/16001/webkit/gpu/webgraphicsconte...
webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc:318:
CHECK(state.error == ::gpu::error::kNoError);
On second thought, can you get rid of the RunAllPending() call here?  I'd be
much happier without it, even if that means we had to change it if we later made
the command buffer scheduler use PostTask().  Right now this is just super scary
code :/

Powered by Google App Engine
This is Rietveld 408576698