Issue 7552029: Revert 96098 - ui_tests began crashing

Issue 7552029: Revert 96098 - ui_tests began crashing (Closed)

Created:
9 years, 4 months ago by Ryan Sleevi

Modified:
9 years, 4 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 96098 - ui_tests began crashing GTTF: Use a fresh TestingBrowserProcess for each test, part #5 For a detailed description see part #1, http://codereview.chromium.org/6478005/ This CL fixes the bug fully on Windows. More platforms will follow. BUG=61062 TEST=unit_tests, possibly more Review URL: http://codereview.chromium.org/7601006 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96107

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -77 lines)			Patch
M	chrome/browser/bookmarks/bookmark_node_data_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/browsing_data_database_helper_browsertest.cc	View	6 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/browsing_data_indexed_db_helper_browsertest.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper_browsertest.cc	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_unittest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/policy/enterprise_metrics_browsertest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/profiles/avatar_menu_model_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility_event_router_views_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/base/chrome_test_suite.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/test/testing_browser_process.cc	View	3 chunks	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

ui_tests began crashing on Win. If you look at your tryjob for patchset 4 of ...

9 years, 4 months ago (2011-08-10 01:14:35 UTC) #2

Paweł Hajdan Jr.

9 years, 4 months ago (2011-08-11 16:36:58 UTC) #3

OK, thank you for watching the tree when I was away. I'm sorry for missing the
trybot failure.

Expand Messages | Collapse Messages