Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa.mm

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove underscore. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_window_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
index c786f399c5b5a38daeb6c0597983b6be704912c9..3d29fce44dd66c7521809fa80254ba31b007e4be 100644
--- a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
#include "chrome/browser/ui/panels/panel.h"
#import "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
@@ -43,7 +44,8 @@ PanelBrowserWindowCocoa::PanelBrowserWindowCocoa(Browser* browser,
: browser_(browser),
panel_(panel),
bounds_(bounds),
- is_shown_(false) {
+ is_shown_(false),
+ has_find_bar_(false) {
controller_ = [[PanelWindowControllerCocoa alloc] initWithBrowserWindow:this];
}
@@ -134,6 +136,16 @@ void PanelBrowserWindowCocoa::ShowTaskManagerForPanel() {
NOTIMPLEMENTED();
}
+FindBar* PanelBrowserWindowCocoa::CreatePanelFindBar() {
+ // Find bar should only be created once per panel!
+ DCHECK(!has_find_bar_);
Dmitry Titov 2011/08/08 20:08:31 It's nice to do it this way, but I don't have a st
jennb 2011/08/08 21:21:21 Done.
+ has_find_bar_ = true;
+
+ FindBarBridge* bridge = new FindBarBridge();
+ [controller_ addFindBar:bridge->find_bar_cocoa_controller()];
+ return bridge;
+}
+
void PanelBrowserWindowCocoa::NotifyPanelOnUserChangedTheme() {
NOTIMPLEMENTED();
}

Powered by Google App Engine
This is Rietveld 408576698