chrome/browser/ui/panels/panel_window_controller_cocoa.h - Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.h

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove underscore. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/panel_browser_window_cocoa.mm ('K') | « chrome/browser/ui/panels/panel_browsertest.cc ('k') | chrome/browser/ui/panels/panel_window_controller_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_window_controller_cocoa.h

diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.h b/chrome/browser/ui/panels/panel_window_controller_cocoa.h

index 6448d68c5ff98ed18b2776e56e9a283900e3c541..4a6908b05388798373d1141e761c99edbcaf836e 100644

--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.h

+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.h

@@ -14,6 +14,7 @@

#import "base/mac/cocoa_protocols.h"

#include "base/memory/scoped_ptr.h"

+@class FindBarCocoaController;

class PanelBrowserWindowCocoa;

@class PanelTitlebarViewCocoa;

@@ -39,6 +40,10 @@ class PanelBrowserWindowCocoa;

// Shows the window for the first time. Only happens once.

- (void)revealAnimatedWithFrame:(const NSRect&)frame;

+// Retains the given FindBarCocoaController and adds its view to this

Dmitry Titov 2011/08/08 20:08:31 In the comment, no need to say "Retains", since t

jennb 2011/08/08 21:21:21 Oops. Forgot to update that comment. Good catch. F

+// Panel. Must only be called once per PanelWindowControllerCocoa.

+- (void)addFindBar:(FindBarCocoaController*)findBarCocoaController;

// Initiate the closing of the panel, starting from the platform-independent

// layer. This will take care of PanelManager, other panels and close the

// native window at the end.