chrome/browser/ui/panels/panel_browser_window_cocoa.h - Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa.h

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove underscore. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/panel_browser_view.cc ('k') | chrome/browser/ui/panels/panel_browser_window_cocoa.mm » ('j') | chrome/browser/ui/panels/panel_browser_window_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_browser_window_cocoa.h

diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.h b/chrome/browser/ui/panels/panel_browser_window_cocoa.h

index fb2d0903531bba64227d80e965af9607384b8af3..74160a8385dd1f20cedc92dcad37cb3c2a7af8d0 100644

--- a/chrome/browser/ui/panels/panel_browser_window_cocoa.h

+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.h

@@ -42,6 +42,7 @@ class PanelBrowserWindowCocoa : public NativePanel,

virtual gfx::NativeWindow GetNativePanelHandle() OVERRIDE;

virtual void UpdatePanelTitleBar() OVERRIDE;

virtual void ShowTaskManagerForPanel() OVERRIDE;

+ virtual FindBar* CreatePanelFindBar() OVERRIDE;

virtual void NotifyPanelOnUserChangedTheme() OVERRIDE;

virtual void DrawAttention() OVERRIDE;

virtual bool IsDrawingAttention() const OVERRIDE;

@@ -67,6 +68,7 @@ class PanelBrowserWindowCocoa : public NativePanel,

gfx::Rect bounds_;

PanelWindowControllerCocoa* controller_; // Weak, owns us.

bool is_shown_; // Panel is hidden on creation, Show() changes that forever.

+ bool has_find_bar_; // Find bar should only be created once per panel.

Dmitry Titov 2011/08/08 20:08:31 Can we make this data member that is only used in

jennb 2011/08/08 21:21:21 As discussed, will not change. DCHECK is not the s

DISALLOW_COPY_AND_ASSIGN(PanelBrowserWindowCocoa);

};