Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2845)

Unified Diff: chrome/browser/ui/cocoa/browser_window_factory.mm

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove underscore. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_factory.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_factory.mm b/chrome/browser/ui/cocoa/browser_window_factory.mm
index c74ca8af2f69cac1c227b0de6423a616b6646aa2..c5611590206e407fca98ece6d99159bf994d7b0f 100644
--- a/chrome/browser/ui/cocoa/browser_window_factory.mm
+++ b/chrome/browser/ui/cocoa/browser_window_factory.mm
@@ -3,9 +3,7 @@
// found in the LICENSE file.
#include "base/basictypes.h"
-#include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
#include "chrome/browser/ui/cocoa/browser_window_controller.h"
-#include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
@@ -17,16 +15,3 @@ BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
[[BrowserWindowController alloc] initWithBrowser:browser];
return [controller browserWindow];
}
-
-// static
-FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
- // We could push the AddFindBar() call into the FindBarBridge
- // constructor or the FindBarCocoaController init, but that makes
- // unit testing difficult, since we would also require a
- // BrowserWindow object.
- BrowserWindowCocoa* window =
- static_cast<BrowserWindowCocoa*>(browser->window());
- FindBarBridge* bridge = new FindBarBridge();
- window->AddFindBar(bridge->find_bar_cocoa_controller());
- return bridge;
-}

Powered by Google App Engine
This is Rietveld 408576698