Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_factory.mm

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove underscore. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
7 #include "chrome/browser/ui/cocoa/browser_window_controller.h" 6 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
8 #include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
9 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_window.h" 8 #include "chrome/browser/ui/browser_window.h"
11 9
12 // Create the controller for the Browser, which handles loading the browser 10 // Create the controller for the Browser, which handles loading the browser
13 // window from the nib. The controller takes ownership of |browser|. 11 // window from the nib. The controller takes ownership of |browser|.
14 // static 12 // static
15 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) { 13 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
16 BrowserWindowController* controller = 14 BrowserWindowController* controller =
17 [[BrowserWindowController alloc] initWithBrowser:browser]; 15 [[BrowserWindowController alloc] initWithBrowser:browser];
18 return [controller browserWindow]; 16 return [controller browserWindow];
19 } 17 }
20
21 // static
22 FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
23 // We could push the AddFindBar() call into the FindBarBridge
24 // constructor or the FindBarCocoaController init, but that makes
25 // unit testing difficult, since we would also require a
26 // BrowserWindow object.
27 BrowserWindowCocoa* window =
28 static_cast<BrowserWindowCocoa*>(browser->window());
29 FindBarBridge* bridge = new FindBarBridge();
30 window->AddFindBar(bridge->find_bar_cocoa_controller());
31 return bridge;
32 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698