Refactor UnionOfKeys into ElementsAccessor

Refactor UnionOfKeys into ElementsAccessor

BUG=none
TEST=none

Committed: http://code.google.com/p/v8/source/detail?r=8870

[danno, 2011-08-09 14:00:49]

Please review.

Guidance: UnionOfDoubleKeys from object.cc has been "templatized" and moved into
the element handler in elements.cc to be able to handle all element types except
non-strict argument, which were not handled fully before.

[Kevin Millikin (Chromium), 2011-08-09 14:46:55]

LGTM.

http://codereview.chromium.org/7529046/diff/1/src/elements.cc
File src/elements.cc (right):

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode44
src/elements.cc:44: if (element->IsSmi() && key->IsSmi() && (element == key))
return true;
If you feel like it, you could write

if (element->IsSmi() && (element == key)) ...

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode107
src/elements.cc:107: // Compute how many elements are not in this.
"not in other".

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode120
src/elements.cc:120: Object* obj;
There's a template member function on MaybeObject that you can use here,
avoiding writing out the cast and the extra variable 'obj':

FixedArray* result;
MaybeObject* maybe_obj =
    other->GetHeap()->AllocateFixedArray(len0 + extra);
if (!maybe_obj->To<FixedArray>(&result)) return maybe_obj;

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode158
src/elements.cc:158: int index) {
Indentation is off here.

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode422
src/elements.cc:422: int index) {
Indentation is off here.

[danno, 2011-08-09 16:38:40]

Addressed feedback and landing.

http://codereview.chromium.org/7529046/diff/1/src/elements.cc
File src/elements.cc (right):

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode44
src/elements.cc:44: if (element->IsSmi() && key->IsSmi() && (element == key))
return true;
On 2011/08/09 14:46:55, Kevin Millikin wrote:
> If you feel like it, you could write
> 
> if (element->IsSmi() && (element == key)) ...

Done.

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode107
src/elements.cc:107: // Compute how many elements are not in this.
On 2011/08/09 14:46:55, Kevin Millikin wrote:
> "not in other".

Done.

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode120
src/elements.cc:120: Object* obj;
On 2011/08/09 14:46:55, Kevin Millikin wrote:
> There's a template member function on MaybeObject that you can use here,
> avoiding writing out the cast and the extra variable 'obj':
> 
> FixedArray* result;
> MaybeObject* maybe_obj =
>     other->GetHeap()->AllocateFixedArray(len0 + extra);
> if (!maybe_obj->To<FixedArray>(&result)) return maybe_obj;

Done.

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode158
src/elements.cc:158: int index) {
On 2011/08/09 14:46:55, Kevin Millikin wrote:
> Indentation is off here.

Done.

http://codereview.chromium.org/7529046/diff/1/src/elements.cc#newcode422
src/elements.cc:422: int index) {
On 2011/08/09 14:46:55, Kevin Millikin wrote:
> Indentation is off here.

Done.