Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: src/elements.h

Issue 7529046: Refactor UnionOfKeys into ElementsAccessor (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 29 matching lines...) Expand all
40 ElementsAccessor() { } 40 ElementsAccessor() { }
41 virtual ~ElementsAccessor() { } 41 virtual ~ElementsAccessor() { }
42 virtual MaybeObject* GetWithReceiver(JSObject* obj, 42 virtual MaybeObject* GetWithReceiver(JSObject* obj,
43 Object* receiver, 43 Object* receiver,
44 uint32_t index) = 0; 44 uint32_t index) = 0;
45 45
46 virtual MaybeObject* Delete(JSObject* obj, 46 virtual MaybeObject* Delete(JSObject* obj,
47 uint32_t index, 47 uint32_t index,
48 JSReceiver::DeleteMode mode) = 0; 48 JSReceiver::DeleteMode mode) = 0;
49 49
50 virtual MaybeObject* AddJSArrayKeysToFixedArray(JSArray* other,
51 FixedArray* keys) = 0;
52
50 // Returns a shared ElementsAccessor for the specified ElementsKind. 53 // Returns a shared ElementsAccessor for the specified ElementsKind.
51 static ElementsAccessor* ForKind(JSObject::ElementsKind elements_kind) { 54 static ElementsAccessor* ForKind(JSObject::ElementsKind elements_kind) {
52 ASSERT(elements_kind < JSObject::kElementsKindCount); 55 ASSERT(elements_kind < JSObject::kElementsKindCount);
53 return elements_accessors_[elements_kind]; 56 return elements_accessors_[elements_kind];
54 } 57 }
55 58
56 static void InitializeOncePerProcess(); 59 static void InitializeOncePerProcess();
57 60
58 private: 61 private:
59 static ElementsAccessor** elements_accessors_; 62 static ElementsAccessor** elements_accessors_;
60 63
61 DISALLOW_COPY_AND_ASSIGN(ElementsAccessor); 64 DISALLOW_COPY_AND_ASSIGN(ElementsAccessor);
62 }; 65 };
63 66
64 } } // namespace v8::internal 67 } } // namespace v8::internal
65 68
66 #endif // V8_ELEMENTS_H_ 69 #endif // V8_ELEMENTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698