Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.h

Issue 7529046: Refactor UnionOfKeys into ElementsAccessor (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/elements.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2110 matching lines...) Expand 10 before | Expand all | Expand 10 after
2121 // Copy operations. 2121 // Copy operations.
2122 MUST_USE_RESULT inline MaybeObject* Copy(); 2122 MUST_USE_RESULT inline MaybeObject* Copy();
2123 MUST_USE_RESULT MaybeObject* CopySize(int new_length); 2123 MUST_USE_RESULT MaybeObject* CopySize(int new_length);
2124 2124
2125 // Add the elements of a JSArray to this FixedArray. 2125 // Add the elements of a JSArray to this FixedArray.
2126 MUST_USE_RESULT MaybeObject* AddKeysFromJSArray(JSArray* array); 2126 MUST_USE_RESULT MaybeObject* AddKeysFromJSArray(JSArray* array);
2127 2127
2128 // Compute the union of this and other. 2128 // Compute the union of this and other.
2129 MUST_USE_RESULT MaybeObject* UnionOfKeys(FixedArray* other); 2129 MUST_USE_RESULT MaybeObject* UnionOfKeys(FixedArray* other);
2130 2130
2131 // Compute the union of this and other.
2132 MUST_USE_RESULT MaybeObject* UnionOfDoubleKeys(
2133 FixedDoubleArray* other);
2134
2135 // Copy a sub array from the receiver to dest. 2131 // Copy a sub array from the receiver to dest.
2136 void CopyTo(int pos, FixedArray* dest, int dest_pos, int len); 2132 void CopyTo(int pos, FixedArray* dest, int dest_pos, int len);
2137 2133
2138 // Garbage collection support. 2134 // Garbage collection support.
2139 static int SizeFor(int length) { return kHeaderSize + length * kPointerSize; } 2135 static int SizeFor(int length) { return kHeaderSize + length * kPointerSize; }
2140 2136
2141 // Code Generation support. 2137 // Code Generation support.
2142 static int OffsetOfElementAt(int index) { return SizeFor(index); } 2138 static int OffsetOfElementAt(int index) { return SizeFor(index); }
2143 2139
2144 // Casting. 2140 // Casting.
(...skipping 5179 matching lines...) Expand 10 before | Expand all | Expand 10 after
7324 } else { 7320 } else {
7325 value &= ~(1 << bit_position); 7321 value &= ~(1 << bit_position);
7326 } 7322 }
7327 return value; 7323 return value;
7328 } 7324 }
7329 }; 7325 };
7330 7326
7331 } } // namespace v8::internal 7327 } } // namespace v8::internal
7332 7328
7333 #endif // V8_OBJECTS_H_ 7329 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/elements.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698