Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7524033: Add a scoper object for URLFetcher::Factory (Closed)

Created:
9 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 4 months ago
CC:
chromium-reviews, GeorgeY, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, ncarter (slow), Raghu Simha, Erik does not do reviews, idana, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr., Ilya Sherman, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Add a scoper object for URLFetcher::Factory This should make it much safer to use (i.e. memory-safe). BUG=90585 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94694

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -616 lines) Patch
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_download_unittest.cc View 5 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/chromeos/login/google_authenticator_unittest.cc View 8 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/online_attempt_unittest.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 12 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/gaia/token_service_unittest.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/policy/cloud_policy_subsystem_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/policy/device_management_service_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/policy/enterprise_metrics_enrollment_browsertest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/policy/testing_policy_url_fetcher_factory.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/policy/testing_policy_url_fetcher_factory.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sync/signin_manager_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 12 chunks +3 lines, -21 lines 0 comments Download
M chrome/common/net/gaia/gaia_oauth_client_unittest.cc View 12 chunks +6 lines, -13 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 3 chunks +1 line, -6 lines 0 comments Download
M content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M content/browser/speech/speech_recognition_request_unittest.cc View 2 chunks +1 line, -10 lines 0 comments Download
M content/browser/speech/speech_recognizer_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
D content/common/test_url_fetcher_factory.h View 1 chunk +0 lines, -227 lines 0 comments Download
D content/common/test_url_fetcher_factory.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M content/common/url_fetcher.h View 4 chunks +17 lines, -15 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
A + content/test/test_url_fetcher_factory.h View 8 chunks +21 lines, -11 lines 0 comments Download
A + content/test/test_url_fetcher_factory.cc View 4 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
Please review: jam, willchan: entire CL; most of it are trivial changes, the meaningful ones ...
9 years, 4 months ago (2011-07-28 18:52:04 UTC) #1
jam
curious, why do you want two reviewers to review the whole change? there should only ...
9 years, 4 months ago (2011-07-28 18:53:04 UTC) #2
akalin
sync stuff LGTM On 2011/07/28 18:52:04, Paweł Hajdan Jr. wrote: > Please review: > > ...
9 years, 4 months ago (2011-07-28 18:56:37 UTC) #3
jam
content lgtm
9 years, 4 months ago (2011-07-28 19:20:58 UTC) #4
willchan no longer on Chromium
9 years, 4 months ago (2011-07-29 08:28:02 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698