Add a scoper object for URLFetcher::Factory

chrome/browser/chromeos/login/online_attempt_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/mock_library_loader.h"
@@ skipping 114 matching lines @@
   TestingProfile profile;
 
   EXPECT_CALL(*(resolver_.get()), Resolve())
       .WillOnce(Invoke(OnlineAttemptTest::Quit))
       .RetiresOnSaturation();
 
   // This is how we inject fake URLFetcher objects, with a factory.
   // This factory creates fake URLFetchers that Start() a fake fetch attempt
   // and then come back on the IO thread saying they've been canceled.
   MockFactory<GotCanceledFetcher> factory;
-  URLFetcher::set_factory(&factory);
 
   attempt_->Initiate(&profile);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableFunction(&OnlineAttemptTest::RunThreadTest));
 
   MessageLoop::current()->Run();
 
   EXPECT_TRUE(error == state_.online_outcome().error());
   EXPECT_EQ(LoginFailure::NETWORK_AUTH_FAILED,
             state_.online_outcome().reason());
-  URLFetcher::set_factory(NULL);
 }
 
 TEST_F(OnlineAttemptTest, LoginTimeout) {
   LoginFailure error(LoginFailure::LOGIN_TIMED_OUT);
   TestingProfile profile;
 
   EXPECT_CALL(*(resolver_.get()), Resolve())
       .WillOnce(Invoke(OnlineAttemptTest::Quit))
       .RetiresOnSaturation();
 
   // This is how we inject fake URLFetcher objects, with a factory.
   // This factory creates fake URLFetchers that Start() a fake fetch attempt
   // and then come back on the IO thread saying they've been canceled.
   MockFactory<ExpectCanceledFetcher> factory;
-  URLFetcher::set_factory(&factory);
 
   attempt_->Initiate(&profile);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableFunction(&OnlineAttemptTest::RunThreadTest));
 
   // Post a task to cancel the login attempt.
   CancelLogin(attempt_.get());
 
   MessageLoop::current()->Run();
 
   EXPECT_EQ(LoginFailure::LOGIN_TIMED_OUT, state_.online_outcome().reason());
-  URLFetcher::set_factory(NULL);
 }
 
 TEST_F(OnlineAttemptTest, HostedLoginRejected) {
   LoginFailure error(
       LoginFailure::FromNetworkAuthFailure(
           GoogleServiceAuthError(
               GoogleServiceAuthError::HOSTED_NOT_ALLOWED)));
   TestingProfile profile;
 
   EXPECT_CALL(*(resolver_.get()), Resolve())
       .WillOnce(Invoke(OnlineAttemptTest::Quit))
       .RetiresOnSaturation();
 
   // This is how we inject fake URLFetcher objects, with a factory.
   MockFactory<HostedFetcher> factory;
-  URLFetcher::set_factory(&factory);
 
   TestAttemptState local_state("", "", "", "", "", true);
   attempt_ = new OnlineAttempt(&local_state, resolver_.get());
   attempt_->Initiate(&profile);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableFunction(&OnlineAttemptTest::RunThreadTest));
 
   MessageLoop::current()->Run();
 
   EXPECT_EQ(error, local_state.online_outcome());
   EXPECT_EQ(LoginFailure::NETWORK_AUTH_FAILED,
             local_state.online_outcome().reason());
-  URLFetcher::set_factory(NULL);
 }
 
 TEST_F(OnlineAttemptTest, FullLogin) {
   TestingProfile profile;
 
   EXPECT_CALL(*(resolver_.get()), Resolve())
       .WillOnce(Invoke(OnlineAttemptTest::Quit))
       .RetiresOnSaturation();
 
   // This is how we inject fake URLFetcher objects, with a factory.
   MockFactory<SuccessFetcher> factory;
-  URLFetcher::set_factory(&factory);
 
   TestAttemptState local_state("", "", "", "", "", true);
   attempt_ = new OnlineAttempt(&local_state, resolver_.get());
   attempt_->Initiate(&profile);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableFunction(&OnlineAttemptTest::RunThreadTest));
 
   MessageLoop::current()->Run();
 
   EXPECT_EQ(LoginFailure::None(), local_state.online_outcome());
-  URLFetcher::set_factory(NULL);
 }
 
 TEST_F(OnlineAttemptTest, LoginNetFailure) {
   RunFailureTest(
       GoogleServiceAuthError::FromConnectionError(net::ERR_CONNECTION_RESET));
 }
 
 TEST_F(OnlineAttemptTest, LoginDenied) {
   RunFailureTest(
       GoogleServiceAuthError(GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
@@ skipping 35 matching lines @@
                         error));
 
   // Force IO thread to finish tasks so I can verify |state_|.
   io_thread_.Stop();
   EXPECT_TRUE(GoogleServiceAuthError::None() ==
               state_.online_outcome().error());
   EXPECT_TRUE(GaiaAuthConsumer::ClientLoginResult() == state_.credentials());
 }
 
 }  // namespace chromeos