Add a scoper object for URLFetcher::Factory

chrome/browser/chromeos/login/google_authenticator_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/google_authenticator.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_path.h"
@@ skipping 540 matching lines @@
       .WillOnce(Return(true))
       .RetiresOnSaturation();
 
   EXPECT_CALL(*mock_library_, GetSystemSalt())
       .WillOnce(Return(salt_v))
       .RetiresOnSaturation();
 
   TestingProfile profile;
 
   MockFactory<MockFetcher> factory;
-  URLFetcher::set_factory(&factory);
 
   scoped_refptr<GoogleAuthenticator> auth(new GoogleAuthenticator(&consumer));
   EXPECT_CALL(*user_manager_.get(), IsKnownUser(username_))
       .WillOnce(Return(true))
       .RetiresOnSaturation();
   auth->set_user_manager(user_manager_.get());
   auth->AuthenticateToLogin(
       &profile, username_, password_, std::string(), std::string());
 
-  URLFetcher::set_factory(NULL);
   message_loop_ui_.RunAllPending();
 }
 
 TEST_F(GoogleAuthenticatorTest, FullHostedLoginFailure) {
   chromeos::CryptohomeBlob salt_v(fake_hash_, fake_hash_ + sizeof(fake_hash_));
 
   LoginFailure failure_details =
       LoginFailure::FromNetworkAuthFailure(
           GoogleServiceAuthError(
               GoogleServiceAuthError::HOSTED_NOT_ALLOWED));
 
   MockConsumer consumer;
   EXPECT_CALL(consumer, OnLoginFailure(failure_details))
       .WillOnce(Invoke(MockConsumer::OnFailQuit))
       .RetiresOnSaturation();
   // A failure case, but we still want the test to finish gracefully.
   ON_CALL(consumer, OnLoginSuccess(username_, password_, _, _))
       .WillByDefault(Invoke(MockConsumer::OnSuccessQuitAndFail));
 
   EXPECT_CALL(*mock_library_, GetSystemSalt())
       .WillOnce(Return(salt_v))
       .RetiresOnSaturation();
 
   TestingProfile profile;
 
   MockFactory<HostedFetcher> factory_invalid;
-  URLFetcher::set_factory(&factory_invalid);
 
   scoped_refptr<GoogleAuthenticator> auth(new GoogleAuthenticator(&consumer));
   auth->set_user_manager(user_manager_.get());
   EXPECT_CALL(*user_manager_.get(), IsKnownUser(username_))
       .WillOnce(Return(false))
       .WillOnce(Return(false))
       .RetiresOnSaturation();
   auth->AuthenticateToLogin(
       &profile, username_, hash_ascii_, std::string(), std::string());
 
   // For when |auth| tries to load the localaccount file.
   BrowserThread file_thread(BrowserThread::FILE);
   file_thread.Start();
 
   // Run the UI thread until we exit it gracefully.
   message_loop_ui_.Run();
-  URLFetcher::set_factory(NULL);
 }
 
 TEST_F(GoogleAuthenticatorTest, CancelLogin) {
   chromeos::CryptohomeBlob salt_v(fake_hash_, fake_hash_ + sizeof(fake_hash_));
 
   MockConsumer consumer;
   // The expected case.
   EXPECT_CALL(consumer, OnLoginFailure(_))
       .WillOnce(Invoke(MockConsumer::OnFailQuit))
       .RetiresOnSaturation();
@@ skipping 10 matching lines @@
       .WillOnce(Return(false))
       .RetiresOnSaturation();
 
   TestingProfile profile;
 
   // This is how we inject fake URLFetcher objects, with a factory.
   // This factory creates fake URLFetchers that Start() a fake fetch attempt
   // and then come back on the UI thread after a small delay.  They expect to
   // be canceled before they come back, and the test will fail if they are not.
   MockFactory<ExpectCanceledFetcher> factory;
-  URLFetcher::set_factory(&factory);
 
   scoped_refptr<GoogleAuthenticator> auth(new GoogleAuthenticator(&consumer));
   // For when |auth| tries to load the localaccount file.
   BrowserThread file_thread(BrowserThread::FILE);
   file_thread.Start();
 
   // Start an authentication attempt, which will kick off a URL "fetch" that
   // we expect to cancel before it completes.
   auth->AuthenticateToLogin(
       &profile, username_, hash_ascii_, std::string(), std::string());
 
   // Post a task to cancel the login attempt.
   CancelLogin(auth.get());
 
-  URLFetcher::set_factory(NULL);
-
   // Run the UI thread until we exit it gracefully.
   message_loop_ui_.Run();
 }
 
 TEST_F(GoogleAuthenticatorTest, CancelLoginAlreadyGotLocalaccount) {
   chromeos::CryptohomeBlob salt_v(fake_hash_, fake_hash_ + sizeof(fake_hash_));
 
   MockConsumer consumer;
   // The expected case.
   EXPECT_CALL(consumer, OnLoginFailure(_))
@@ skipping 12 matching lines @@
       .WillOnce(Return(false))
       .RetiresOnSaturation();
 
   TestingProfile profile;
 
   // This is how we inject fake URLFetcher objects, with a factory.
   // This factory creates fake URLFetchers that Start() a fake fetch attempt
   // and then come back on the UI thread after a small delay.  They expect to
   // be canceled before they come back, and the test will fail if they are not.
   MockFactory<ExpectCanceledFetcher> factory;
-  URLFetcher::set_factory(&factory);
 
   scoped_refptr<GoogleAuthenticator> auth(new GoogleAuthenticator(&consumer));
   // This time, instead of allowing |auth| to go get the localaccount file
   // itself, we simulate the case where the file is already loaded, which
   // happens when this isn't the first login since chrome started.
   ReadLocalaccountFile(auth.get(), "");
 
   // Start an authentication attempt, which will kick off a URL "fetch" that
   // we expect to cancel before it completes.
   auth->AuthenticateToLogin(
       &profile, username_, hash_ascii_, std::string(), std::string());
 
   // Post a task to cancel the login attempt.
   CancelLogin(auth.get());
 
-  URLFetcher::set_factory(NULL);
-
   // Run the UI thread until we exit it gracefully.
   message_loop_ui_.Run();
 }
 
 }  // namespace chromeos