Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 7493050: Do not interfere with git cl patch <issue> (Closed)

Created:
9 years, 5 months ago by M-A Ruel
Modified:
9 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Nico
Visibility:
Public.

Description

Do not interfere with git cl patch <issue> R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94004

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make sense out of comment #

Total comments: 1

Patch Set 3 : Remove confusing command #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M presubmit_canned_checks.py View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 5 months ago (2011-07-25 01:22:26 UTC) #1
Dirk Pranke
http://codereview.chromium.org/7493050/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/7493050/diff/1/presubmit_canned_checks.py#newcode70 presubmit_canned_checks.py:70: # If patchset is None, it's likely a patchset ...
9 years, 5 months ago (2011-07-25 19:06:54 UTC) #2
M-A Ruel
http://codereview.chromium.org/7493050/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/7493050/diff/1/presubmit_canned_checks.py#newcode70 presubmit_canned_checks.py:70: # If patchset is None, it's likely a patchset ...
9 years, 5 months ago (2011-07-25 19:10:01 UTC) #3
Dirk Pranke
http://codereview.chromium.org/7493050/diff/5001/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/7493050/diff/5001/presubmit_canned_checks.py#newcode72 presubmit_canned_checks.py:72: # by a committer to be checked-in. Okay, I ...
9 years, 5 months ago (2011-07-25 21:03:15 UTC) #4
M-A Ruel
done
9 years, 5 months ago (2011-07-26 00:28:18 UTC) #5
Dirk Pranke
9 years, 5 months ago (2011-07-26 00:29:48 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld 408576698