presubmit_canned_checks.py - Issue 7493050: Do not interfere with git cl patch <issue>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 7493050: Do not interfere with git cl patch <issue> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Remove confusing command Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index a69bacee4ebd630a8377bfa1983b201e9be3e75b..137c376415b79c54b8b867b8e943b06b9379b800 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -66,8 +66,7 @@ def CheckChangeHasDescription(input_api, output_api):

def CheckChangeWasUploaded(input_api, output_api):

"""Checks that the issue was uploaded before committing."""

- if (input_api.is_committing and

- (not input_api.change.issue or not input_api.change.patchset)):

+ if input_api.is_committing and not input_api.change.issue:

return [output_api.PresubmitError(

'Issue wasn\'t uploaded. Please upload first.')]

return []

« no previous file with comments | « no previous file | no next file » | no next file with comments »