Do not interfere with git cl patch <issue>

presubmit_canned_checks.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
@@ skipping 48 matching lines @@
   if text.strip() == '':
     if input_api.is_committing:
       return [output_api.PresubmitError('Add a description.')]
     else:
       return [output_api.PresubmitNotifyResult('Add a description.')]
   return []
 
 
 def CheckChangeWasUploaded(input_api, output_api):
   """Checks that the issue was uploaded before committing."""
-  if (input_api.is_committing and
-      (not input_api.change.issue or not input_api.change.patchset)):
+  if input_api.is_committing and not input_api.change.issue:
+    # If patchset is None, it's likely a patchset in issue.

[Dirk Pranke, 2011/07/25 19:06:54]

I don't follow this comment?

[M-A Ruel, 2011/07/25 19:10:01]

That's normal, it didn't make sense either. Fixed.

     return [output_api.PresubmitError(
       'Issue wasn\'t uploaded. Please upload first.')]
   return []
 
 
 ### Content checks
 
 def CheckDoNotSubmitInFiles(input_api, output_api):
   """Checks that the user didn't add 'DO NOT ' + 'SUBMIT' to any files."""
   # We want to check every text file, not just source files.
@@ skipping 856 matching lines @@
     results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
         input_api, output_api))
     snapshot("checking license")
     results.extend(input_api.canned_checks.CheckLicense(
         input_api, output_api, license_header, source_file_filter=sources))
     snapshot("checking was uploaded")
     results.extend(input_api.canned_checks.CheckChangeWasUploaded(
         input_api, output_api))
   snapshot("done")
   return results