Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7477008: Remove explicit keyword from multi-argument constructors (Closed)

Created:
9 years, 5 months ago by Denis Lagno
Modified:
9 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, asanka, kkania, amit, cbentzel+watch_chromium.org, stuartmorgan+watch_chromium.org, ajwong+watch_chromium.org, dhollowa, ncarter (slow), nkostylev+cc_chromium.org, idana, Erik does not do reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), michaeln, dmaclach+watch_chromium.org, wez+watch_chromium.org, Raghu Simha, Randy Smith (Not in Mondays), simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove explicit keyword from multi-argument (w/o default values) constructors BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -211 lines) Patch
M base/win/scoped_variant.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/burn_library.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mock_authenticator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/rounded_rect_painter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/setting_level_bubble.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_pref_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_quota_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/text_database_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_data_remover_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_policy_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/syncable_service_adapter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_mac.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/custom_drag.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_container_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/link_infobar_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/side_tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/webdata/web_database_table.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/json_pref_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/custom_sync_call_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/test_automation_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/test_server.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/zygote_main_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/process_watcher_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/disk_cache/mapped_file_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/disk_cache/stats_histogram.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/server/http_server.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_test_job.h View 1 chunk +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_throttler_entry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/font_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_transport.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/client/plugin/chromoting_scriptable_object.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/content_description.h View 1 chunk +4 lines, -4 lines 0 comments Download
M sandbox/src/crosscall_params.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_platform_device_cairo_linux.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/traceline/traceline/assembler.h View 1 chunk +3 lines, -8 lines 0 comments Download
M ui/gfx/gl/gl_surface_egl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/gfx/gl/gl_surface_osmesa.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_scroll_view_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/drop_target_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Denis Lagno
please take a look
9 years, 5 months ago (2011-07-26 13:01:26 UTC) #1
brettw
9 years, 5 months ago (2011-07-26 16:16:16 UTC) #2 
LGTM rubberstamp

Powered by Google App Engine
This is Rietveld 408576698