[Sync] Support receiving early passphrase required information in Sync UI.

[Sync] Support receiving early passphrase required information in Sync UI.

We now always send the configure command, even when it's just a passphrase
being entered. This works because the datatypemanager now is smart enough
to not reconfigure if the datatypes are the same and we were already in a
configured state. The configure command now also supports using the explicit
passphrase prompted when one is already required.

BUG=87797, 87572
TEST=First time sync on an account that already had an explicit passphrase. Also all other passphrase prompt scenarios.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93549

[Nicolas Zea, 2011-07-21 00:26:32]

This is still a WIP, but it does solve the issue currently present where you are
unable to fully set up sync if you already had an explicit passphrase. Currently
there's still a UI issue where while sync is configuring the datatypes it shows
"incorrect passphrase", even though the passphrase is correct.

In addition I need to verify that this works when an explicit passphrase is set
from a different client and then syncs over (triggering the passwords needs your
attention flow). Figure I'd go ahead and give you both a change to give some
early feedback though

[binji, 2011-07-21 01:04:36]

http://codereview.chromium.org/7466024/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/7466024/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:227: var
custom_passphrase = "";
nit: javascript variable style is camelCase.

http://codereview.chromium.org/7466024/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:228: if
($('sync-existing-passphrase-container').hidden == false) {
nit: remove == false

[tim (not reviewing), 2011-07-21 16:29:30]

c++ changes LGTM

[Nicolas Zea, 2011-07-21 18:20:49]

PTAL. I also made it so that CLEAR_PENDING is always handled, since we're
currently getting it on the nigori download which happens before we reach the
configure screen. I tested that this successfully leads to the "sync server is
busy please retry later" screen.

This should solve most passphrase issues, with the exception of the "passphrase
needs your attention" link leading to a crash, which I filed crbug.com/90058 on.

http://codereview.chromium.org/7466024/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/7466024/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:227: var
custom_passphrase = "";
On 2011/07/21 01:04:36, binji wrote:
> nit: javascript variable style is camelCase.

Done.

http://codereview.chromium.org/7466024/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:228: if
($('sync-existing-passphrase-container').hidden == false) {
On 2011/07/21 01:04:36, binji wrote:
> nit: remove == false

Done.

[Nicolas Zea, 2011-07-21 18:21:33]

FYI drew

[binji, 2011-07-21 18:24:44]

+jhawkins. I'm not a full committer yet!

[James Hawkins, 2011-07-21 19:20:09]

LGTM with nits.

http://codereview.chromium.org/7466024/diff/4002/chrome/browser/resources/opt...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/7466024/diff/4002/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:219: if
(!this.checkPassphraseMatch_()) {
No braces for single-line logic blocks, here and elsewhere.

http://codereview.chromium.org/7466024/diff/4002/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:232: var customPassphrase
= "";
No need to initialize to empty string.

[Nicolas Zea, 2011-07-21 19:34:57]

Comments addressed. Committing once trybots go green.

http://codereview.chromium.org/7466024/diff/4002/chrome/browser/resources/opt...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/7466024/diff/4002/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:219: if
(!this.checkPassphraseMatch_()) {
On 2011/07/21 19:20:09, James Hawkins wrote:
> No braces for single-line logic blocks, here and elsewhere.

Done.

http://codereview.chromium.org/7466024/diff/4002/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:232: var customPassphrase
= "";
On 2011/07/21 19:20:09, James Hawkins wrote:
> No need to initialize to empty string.

Done.

[commit-bot: I haz the power, 2011-07-22 04:28:01]

Change committed as 93549