Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/browser/sync/sync_setup_flow.cc

Issue 7466024: [Sync] Support receiving early passphrase required information in Sync UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed + fix unit test Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_setup_flow.h" 5 #include "chrome/browser/sync/sync_setup_flow.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 syncable::ModelTypeSet data_types; 260 syncable::ModelTypeSet data_types;
261 service_->GetRegisteredDataTypes(&data_types); 261 service_->GetRegisteredDataTypes(&data_types);
262 service_->EncryptDataTypes(data_types); 262 service_->EncryptDataTypes(data_types);
263 } 263 }
264 264
265 // If we are activating the passphrase, we need to have one supplied. 265 // If we are activating the passphrase, we need to have one supplied.
266 DCHECK(service_->IsUsingSecondaryPassphrase() || 266 DCHECK(service_->IsUsingSecondaryPassphrase() ||
267 !configuration.use_secondary_passphrase || 267 !configuration.use_secondary_passphrase ||
268 configuration.secondary_passphrase.length() > 0); 268 configuration.secondary_passphrase.length() > 0);
269 269
270 if (configuration.use_secondary_passphrase && 270 if (configuration.use_secondary_passphrase) {
271 !service_->IsUsingSecondaryPassphrase()) { 271 if (!service_->IsUsingSecondaryPassphrase()) {
272 service_->SetPassphrase(configuration.secondary_passphrase, true, true); 272 service_->SetPassphrase(configuration.secondary_passphrase, true, true);
273 tried_creating_explicit_passphrase_ = true; 273 tried_creating_explicit_passphrase_ = true;
274 } else {
275 service_->SetPassphrase(configuration.secondary_passphrase, true, false);
276 tried_setting_explicit_passphrase_ = true;
277 }
274 } 278 }
275 279
276 service_->OnUserChoseDatatypes(configuration.sync_everything, 280 service_->OnUserChoseDatatypes(configuration.sync_everything,
277 configuration.data_types); 281 configuration.data_types);
278 } 282 }
279 283
280 void SyncSetupFlow::OnPassphraseEntry(const std::string& passphrase) { 284 void SyncSetupFlow::OnPassphraseEntry(const std::string& passphrase) {
281 Advance(SyncSetupWizard::SETTING_UP); 285 Advance(SyncSetupWizard::SETTING_UP);
282 service_->SetPassphrase(passphrase, true, false); 286 service_->SetPassphrase(passphrase, true, false);
283 tried_setting_explicit_passphrase_ = true; 287 tried_setting_explicit_passphrase_ = true;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 case SyncSetupWizard::GAIA_SUCCESS: 323 case SyncSetupWizard::GAIA_SUCCESS:
320 return current_state_ == SyncSetupWizard::GAIA_LOGIN; 324 return current_state_ == SyncSetupWizard::GAIA_LOGIN;
321 case SyncSetupWizard::SYNC_EVERYTHING: 325 case SyncSetupWizard::SYNC_EVERYTHING:
322 case SyncSetupWizard::CONFIGURE: 326 case SyncSetupWizard::CONFIGURE:
323 return current_state_ == SyncSetupWizard::GAIA_SUCCESS; 327 return current_state_ == SyncSetupWizard::GAIA_SUCCESS;
324 case SyncSetupWizard::ENTER_PASSPHRASE: 328 case SyncSetupWizard::ENTER_PASSPHRASE:
325 return current_state_ == SyncSetupWizard::SYNC_EVERYTHING || 329 return current_state_ == SyncSetupWizard::SYNC_EVERYTHING ||
326 current_state_ == SyncSetupWizard::CONFIGURE || 330 current_state_ == SyncSetupWizard::CONFIGURE ||
327 current_state_ == SyncSetupWizard::SETTING_UP; 331 current_state_ == SyncSetupWizard::SETTING_UP;
328 case SyncSetupWizard::SETUP_ABORTED_BY_PENDING_CLEAR: 332 case SyncSetupWizard::SETUP_ABORTED_BY_PENDING_CLEAR:
329 return (current_state_ != SyncSetupWizard::GAIA_LOGIN && 333 return true; // The server can abort whenever it wants.
330 current_state_ != SyncSetupWizard::GAIA_SUCCESS);
331 case SyncSetupWizard::SETTING_UP: 334 case SyncSetupWizard::SETTING_UP:
332 return current_state_ == SyncSetupWizard::SYNC_EVERYTHING || 335 return current_state_ == SyncSetupWizard::SYNC_EVERYTHING ||
333 current_state_ == SyncSetupWizard::CONFIGURE || 336 current_state_ == SyncSetupWizard::CONFIGURE ||
334 current_state_ == SyncSetupWizard::ENTER_PASSPHRASE; 337 current_state_ == SyncSetupWizard::ENTER_PASSPHRASE;
335 case SyncSetupWizard::NONFATAL_ERROR: 338 case SyncSetupWizard::NONFATAL_ERROR:
336 case SyncSetupWizard::FATAL_ERROR: 339 case SyncSetupWizard::FATAL_ERROR:
337 return true; // You can always hit the panic button. 340 return true; // You can always hit the panic button.
338 case SyncSetupWizard::DONE: 341 case SyncSetupWizard::DONE:
339 return current_state_ == SyncSetupWizard::SETTING_UP || 342 return current_state_ == SyncSetupWizard::SETTING_UP ||
340 current_state_ == SyncSetupWizard::ENTER_PASSPHRASE; 343 current_state_ == SyncSetupWizard::ENTER_PASSPHRASE;
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 break; 412 break;
410 } 413 }
411 case SyncSetupWizard::DONE: 414 case SyncSetupWizard::DONE:
412 flow_handler_->ShowSetupDone( 415 flow_handler_->ShowSetupDone(
413 UTF16ToWide(service_->GetAuthenticatedUsername())); 416 UTF16ToWide(service_->GetAuthenticatedUsername()));
414 break; 417 break;
415 default: 418 default:
416 NOTREACHED() << "Invalid advance state: " << state; 419 NOTREACHED() << "Invalid advance state: " << state;
417 } 420 }
418 } 421 }
OLDNEW
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/sync/sync_setup_wizard_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698