chrome/browser/sync/engine/syncapi.cc - Issue 7466024: [Sync] Support receiving early passphrase required information in Sync UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/syncapi.cc

Issue 7466024: [Sync] Support receiving early passphrase required information in Sync UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed + fix unit test Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/engine/syncapi.cc

diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc

index fe54eacc936dd47020e67e843eca77ea5088c047..d1f99dd8d3fa841fcc5253028f19250381ea0f0b 100644

--- a/chrome/browser/sync/engine/syncapi.cc

+++ b/chrome/browser/sync/engine/syncapi.cc

@@ -1966,7 +1966,7 @@ void SyncManager::SyncInternal::SetPassphrase(

const std::string& passphrase, bool is_explicit) {

// We do not accept empty passphrases.

if (passphrase.empty()) {

- VLOG(1) << "Rejecting empty passphrase.";

+ NOTREACHED() << "Rejecting empty passphrase.";

ObserverList<SyncManager::Observer> temp_obs_list;

CopyObservers(&temp_obs_list);

FOR_EACH_OBSERVER(SyncManager::Observer, temp_obs_list,

« no previous file with comments | « chrome/browser/resources/options/sync_setup_overlay.js ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »