| Index: chrome/test/live_sync/performance/extensions_sync_perf_test.cc
|
| diff --git a/chrome/test/live_sync/performance/extensions_sync_perf_test.cc b/chrome/test/live_sync/performance/extensions_sync_perf_test.cc
|
| index f66f10740480fadb67da262380bc5967aea460c7..76e519569aa5786d3815f607946f26aefeb65e27 100644
|
| --- a/chrome/test/live_sync/performance/extensions_sync_perf_test.cc
|
| +++ b/chrome/test/live_sync/performance/extensions_sync_perf_test.cc
|
| @@ -9,16 +9,14 @@
|
|
|
| // TODO(braffert): Replicate these tests for apps.
|
|
|
| +// TODO(braffert): Move kNumBenchmarkPoints and kBenchmarkPoints for all
|
| +// datatypes into a performance test base class, once it is possible to do so.
|
| static const int kNumExtensions = 150;
|
| -
|
| -// TODO(braffert): Consider the range / resolution of these test points.
|
| static const int kNumBenchmarkPoints = 18;
|
| static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
|
| 150, 175, 200, 225, 250, 300, 350, 400,
|
| 500};
|
|
|
| -// TODO(braffert): Move this class into its own .h/.cc files. What should the
|
| -// class files be named as opposed to the file containing the tests themselves?
|
| class ExtensionsSyncPerfTest
|
| : public TwoClientLiveExtensionsSyncTest {
|
| public:
|
| @@ -87,8 +85,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, Add) {
|
| InstallExtensionsPendingForSync(GetProfile(1));
|
| ASSERT_TRUE(AllProfilesHaveSameExtensions());
|
|
|
| - // TODO(braffert): Compare timings against some target value.
|
| - VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
|
| + SyncTimingHelper::PrintResult("extensions", "add", dt);
|
| }
|
|
|
| // TCM ID - 7655397.
|
| @@ -104,8 +101,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, Update) {
|
| SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
|
| ASSERT_TRUE(AllProfilesHaveSameExtensions());
|
|
|
| - // TODO(braffert): Compare timings against some target value.
|
| - VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
|
| + SyncTimingHelper::PrintResult("extensions", "update", dt);
|
| }
|
|
|
| // TCM ID - 7567721.
|
| @@ -121,8 +117,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, Delete) {
|
| SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
|
| ASSERT_TRUE(AllProfilesHaveSameExtensions());
|
|
|
| - // TODO(braffert): Compare timings against some target value.
|
| - VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
|
| + SyncTimingHelper::PrintResult("extensions", "delete", dt);
|
| }
|
|
|
| IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, DISABLED_Benchmark) {
|
|
|