| Index: chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc
|
| diff --git a/chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc b/chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc
|
| index a040aec24ace747eea18a73c5ee7c903558175d7..a08a32fbb16c217edaf7dcfa0d06b8d2b6f8aaca 100644
|
| --- a/chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc
|
| +++ b/chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc
|
| @@ -6,16 +6,14 @@
|
| #include "chrome/test/live_sync/live_bookmarks_sync_test.h"
|
| #include "chrome/test/live_sync/performance/sync_timing_helper.h"
|
|
|
| +// TODO(braffert): Move kNumBenchmarkPoints and kBenchmarkPoints for all
|
| +// datatypes into a performance test base class, once it is possible to do so.
|
| static const int kNumBookmarks = 150;
|
| -
|
| -// TODO(braffert): Consider the range / resolution of these test points.
|
| static const int kNumBenchmarkPoints = 18;
|
| static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
|
| 150, 175, 200, 225, 250, 300, 350, 400,
|
| 500};
|
|
|
| -// TODO(braffert): Move this class into its own .h/.cc files. What should the
|
| -// class files be named as opposed to the file containing the tests themselves?
|
| class BookmarksSyncPerfTest
|
| : public TwoClientLiveBookmarksSyncTest {
|
| public:
|
| @@ -94,8 +92,7 @@ IN_PROC_BROWSER_TEST_F(BookmarksSyncPerfTest, Add) {
|
| ASSERT_EQ(kNumBookmarks, GetBookmarkBarNode(0)->child_count());
|
| ASSERT_TRUE(AllModelsMatch());
|
|
|
| - // TODO(braffert): Compare timings against some target value.
|
| - VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
|
| + SyncTimingHelper::PrintResult("bookmarks", "add", dt);
|
| }
|
|
|
| // TCM ID - 7564762.
|
| @@ -112,8 +109,7 @@ IN_PROC_BROWSER_TEST_F(BookmarksSyncPerfTest, Update) {
|
| ASSERT_EQ(kNumBookmarks, GetBookmarkBarNode(0)->child_count());
|
| ASSERT_TRUE(AllModelsMatch());
|
|
|
| - // TODO(braffert): Compare timings against some target value.
|
| - VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
|
| + SyncTimingHelper::PrintResult("bookmarks", "update", dt);
|
| }
|
|
|
| // TCM ID - 7566626.
|
| @@ -130,8 +126,7 @@ IN_PROC_BROWSER_TEST_F(BookmarksSyncPerfTest, Delete) {
|
| ASSERT_EQ(0, GetBookmarkBarNode(0)->child_count());
|
| ASSERT_TRUE(AllModelsMatch());
|
|
|
| - // TODO(braffert): Compare timings against some target value.
|
| - VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
|
| + SyncTimingHelper::PrintResult("bookmarks", "delete", dt);
|
| }
|
|
|
| IN_PROC_BROWSER_TEST_F(BookmarksSyncPerfTest, DISABLED_Benchmark) {
|
|
|