Sync performance tests: Cleanup TODOs and print in dashboard friendly format

chrome/test/live_sync/performance/extensions_sync_perf_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stringprintf.h"
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 #include "chrome/test/live_sync/live_extensions_sync_test.h"
 #include "chrome/test/live_sync/performance/sync_timing_helper.h"
 
 // TODO(braffert): Replicate these tests for apps.
 
+// TODO(braffert): Move kNumBenchmarkPoints and kBenchmarkPoints for all
+// datatypes into a performance test base class, once it is possible to do so.
 static const int kNumExtensions = 150;
-
-// TODO(braffert): Consider the range / resolution of these test points.
 static const int kNumBenchmarkPoints = 18;
 static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
                                        150, 175, 200, 225, 250, 300, 350, 400,
                                        500};
 
-// TODO(braffert): Move this class into its own .h/.cc files.  What should the
-// class files be named as opposed to the file containing the tests themselves?
 class ExtensionsSyncPerfTest
     : public TwoClientLiveExtensionsSyncTest {
  public:
   ExtensionsSyncPerfTest() : extension_number_(0) {}
 
   // Adds |num_extensions| new unique extensions to |profile|.
   void AddExtensions(int profile, int num_extensions);
 
   // Updates the enabled/disabled state for all extensions in |profile|.
   void UpdateExtensions(int profile);
@@ skipping 48 matching lines @@
 // TCM ID - 7563874.
 IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, Add) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddExtensions(0, kNumExtensions);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   InstallExtensionsPendingForSync(GetProfile(1));
   ASSERT_TRUE(AllProfilesHaveSameExtensions());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("extensions", "add", dt);
 }
 
 // TCM ID - 7655397.
 IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, Update) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddExtensions(0, kNumExtensions);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
   InstallExtensionsPendingForSync(GetProfile(1));
 
   UpdateExtensions(0);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_TRUE(AllProfilesHaveSameExtensions());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("extensions", "update", dt);
 }
 
 // TCM ID - 7567721.
 IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, Delete) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddExtensions(0, kNumExtensions);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
   InstallExtensionsPendingForSync(GetProfile(1));
 
   RemoveExtensions(0);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_TRUE(AllProfilesHaveSameExtensions());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("extensions", "delete", dt);
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, DISABLED_Benchmark) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   for (int i = 0; i < kNumBenchmarkPoints; ++i) {
     int num_extensions = kBenchmarkPoints[i];
     AddExtensions(0, num_extensions);
     base::TimeDelta dt_add =
         SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
     InstallExtensionsPendingForSync(GetProfile(1));
     VLOG(0) << std::endl << "Add: " << num_extensions << " "
             << dt_add.InSecondsF();
 
     UpdateExtensions(0);
     base::TimeDelta dt_update =
         SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
     VLOG(0) << std::endl << "Update: " << num_extensions << " "
             << dt_update.InSecondsF();
 
     RemoveExtensions(0);
     base::TimeDelta dt_delete =
         SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
     VLOG(0) << std::endl << "Delete: " << num_extensions << " "
             << dt_delete.InSecondsF();
 
     Cleanup();
   }
 }