Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/test/live_sync/performance/autofill_sync_perf_test.cc

Issue 7464046: Sync performance tests: Cleanup TODOs and print in dashboard friendly format (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add benchmark points TODO to all datatypes Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/live_sync/performance/autofill_sync_perf_test.cc
diff --git a/chrome/test/live_sync/performance/autofill_sync_perf_test.cc b/chrome/test/live_sync/performance/autofill_sync_perf_test.cc
index a7a18c602ba3c796ddecc0a09cade2cd5604c5d4..88d96f724b941361227719dd64280c2e339c3214 100644
--- a/chrome/test/live_sync/performance/autofill_sync_perf_test.cc
+++ b/chrome/test/live_sync/performance/autofill_sync_perf_test.cc
@@ -8,16 +8,14 @@
#include "chrome/test/live_sync/live_autofill_sync_test.h"
#include "chrome/test/live_sync/performance/sync_timing_helper.h"
+// TODO(braffert): Move kNumBenchmarkPoints and kBenchmarkPoints for all
+// datatypes into a performance test base class, once it is possible to do so.
static const int kNumProfiles = 150;
-
-// TODO(braffert): Consider the range / resolution of these test points.
static const int kNumBenchmarkPoints = 18;
static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
150, 175, 200, 225, 250, 300, 350, 400,
500};
-// TODO(braffert): Move this class into its own .h/.cc files. What should the
-// class files be named as opposed to the file containing the tests themselves?
class AutofillSyncPerfTest
: public TwoClientLiveAutofillSyncTest {
public:
@@ -127,8 +125,7 @@ IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Add) {
ASSERT_EQ(kNumProfiles, GetProfileCount(0));
ASSERT_TRUE(AllProfilesMatch());
- // TODO(braffert): Compare timings against some target value.
- VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+ SyncTimingHelper::PrintResult("autofill", "add", dt);
}
// TCM ID - 7549835.
@@ -144,8 +141,7 @@ IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Update) {
ASSERT_EQ(kNumProfiles, GetProfileCount(0));
ASSERT_TRUE(AllProfilesMatch());
- // TODO(braffert): Compare timings against some target value.
- VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+ SyncTimingHelper::PrintResult("autofill", "update", dt);
}
// TCM ID - 7553678.
@@ -161,8 +157,7 @@ IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Delete) {
ASSERT_EQ(0, GetProfileCount(0));
ASSERT_TRUE(AllProfilesMatch());
- // TODO(braffert): Compare timings against some target value.
- VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+ SyncTimingHelper::PrintResult("autofill", "delete", dt);
}
IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, DISABLED_Benchmark) {
« no previous file with comments | « no previous file | chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698