Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 7461152: Gets rid of chrome being cleared for a moment when keyboard is hidden (Closed)

Created:
9 years, 4 months ago by pkotwicz
Modified:
9 years, 4 months ago
Reviewers:
sky, jonathan.backer
CC:
chromium-reviews
Visibility:
Public.

Description

Gets rid of chrome being cleared for a moment when keyboard is hidden When the keyboard was hidden, the chrome would be temporarily hidden while the ui was layed out. This patch gets rid of this. The problem was that the texture bounds is delayed some delay after the layer bounds are set. This would make the math fail inside drawInternal BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96557

Patch Set 1 #

Patch Set 2 : removed extraneous code #

Total comments: 1

Patch Set 3 : Modified variable name in all relevant files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M chrome/browser/renderer_host/accelerated_surface_container_touch.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/compositor/compositor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/compositor_gl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/compositor/compositor_gl.cc View 1 2 1 chunk +7 lines, -3 lines 1 comment Download
M ui/gfx/compositor/compositor_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
9 years, 4 months ago (2011-08-10 22:08:59 UTC) #1
pkotwicz
9 years, 4 months ago (2011-08-10 22:09:03 UTC) #2
jonathan.backer
On 2011/08/10 22:09:03, pkotwicz wrote: LGTM
9 years, 4 months ago (2011-08-10 22:13:05 UTC) #3
jonathan.backer
http://codereview.chromium.org/7461152/diff/1001/ui/gfx/compositor/compositor_gl.cc File ui/gfx/compositor/compositor_gl.cc (right): http://codereview.chromium.org/7461152/diff/1001/ui/gfx/compositor/compositor_gl.cc#newcode345 ui/gfx/compositor/compositor_gl.cc:345: const gfx::Rect& clip_bounds_in_layer) { How about we call it ...
9 years, 4 months ago (2011-08-11 11:52:52 UTC) #4
sky
9 years, 4 months ago (2011-08-17 15:53:57 UTC) #5
LGTM

http://codereview.chromium.org/7461152/diff/6001/ui/gfx/compositor/compositor...
File ui/gfx/compositor/compositor_gl.cc (right):

http://codereview.chromium.org/7461152/diff/6001/ui/gfx/compositor/compositor...
ui/gfx/compositor/compositor_gl.cc:346: // clip clip_bounds_in_layer to size of
texture
-> Clip clip_bounds_in_texture to current size.

Powered by Google App Engine
This is Rietveld 408576698