Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 7461142: [ChromeOS] Assorted WebUI login fixes. (Closed)

Created:
9 years, 4 months ago by xiyuan
Modified:
9 years, 4 months ago
Reviewers:
zel
CC:
chromium-reviews, arv (Not doing code reviews), rharrison, davemoore+watch_chromium.org, nkostylev+cc_chromium.org
Visibility:
Public.

Description

[ChromeOS] Assorted WebUI login fixes. - Respect account settings by using the users list and other flags passed into WebUILoginDisplay::Init; - Limit max 5 users to avoid scrolling in account picker; - Increase account picker width to 1100px to avoid crop on user pods; - Properly remove a user, i.e. go through UserManager::RemoveUser instead of delete it directly using RemoveUserFromList; - Improve the tab order; - Switch to Gaia sign in if user failed login three times in a row; - Turn off init animation; BUG=chromium-os:18532, chromium-os:18668, chromium-os:18312, chromium-os:18307 TEST=Verify fix for chromium-os:18532,chromium-os:18668,chrmoum-os:18312 and chromium-os:18307. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95551

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment in #1 #

Messages

Total messages: 3 (0 generated)
xiyuan
9 years, 4 months ago (2011-08-04 23:12:34 UTC) #1
zel
LGTM http://codereview.chromium.org/7461142/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right): http://codereview.chromium.org/7461142/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js#newcode53 chrome/browser/resources/chromeos/login/screen_gaia_signin.js:53: console.log('Opening extension: ' + JSON.stringify(data)); please make sure ...
9 years, 4 months ago (2011-08-05 00:01:48 UTC) #2
xiyuan
9 years, 4 months ago (2011-08-05 01:04:12 UTC) #3
Done and submitting...

http://codereview.chromium.org/7461142/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

http://codereview.chromium.org/7461142/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:53:
console.log('Opening extension: ' + JSON.stringify(data));
On 2011/08/05 00:01:49, zel wrote:
> please make sure we have no private info of any sort dumped here

Done. Changed to just output startUrl and email property of data.

Powered by Google App Engine
This is Rietveld 408576698