Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3595)

Unified Diff: chrome/browser/resources/chromeos/login/bubble.js

Issue 7461142: [ChromeOS] Assorted WebUI login fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comment in #1 Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/bubble.js
diff --git a/chrome/browser/resources/chromeos/login/bubble.js b/chrome/browser/resources/chromeos/login/bubble.js
index 7e55b2edd06b58bbe234d4b79238ebc442c7f176..7b1bf2fab2cbf58c60cd2be401f4afee27fbf6a3 100644
--- a/chrome/browser/resources/chromeos/login/bubble.js
+++ b/chrome/browser/resources/chromeos/login/bubble.js
@@ -24,7 +24,9 @@ cr.define('cr.ui', function() {
/** @inheritDoc */
decorate: function() {
this.ownerDocument.addEventListener('click',
- this.handleClick_.bind(this));
+ this.handleDocClick_.bind(this));
+ this.ownerDocument.addEventListener('keydown',
+ this.handleDocKeyDown_.bind(this));
this.addEventListener('webkitTransitionEnd',
this.handleTransitionEnd_.bind(this));
},
@@ -84,16 +86,25 @@ cr.define('cr.ui', function() {
},
/**
- * Handler of click event.
+ * Handler of document click event.
* @private
*/
- handleClick_: function(e) {
+ handleDocClick_: function(e) {
// Ignore clicks on anchor element.
if (e.target == this.anchor_)
return;
if (!this.hidden)
this.hide();
+ },
+
+ /**
+ * Handle of document keydown event.
+ * @private
+ */
+ handleDocKeyDown_: function(e) {
+ if (!this.hidden)
+ this.hide();
}
};
« no previous file with comments | « chrome/browser/chromeos/login/webui_login_display.cc ('k') | chrome/browser/resources/chromeos/login/oobe.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698