Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: chrome/browser/resources/chromeos/login/oobe.js

Issue 7461142: [ChromeOS] Assorted WebUI login fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comment in #1 Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe.js
diff --git a/chrome/browser/resources/chromeos/login/oobe.js b/chrome/browser/resources/chromeos/login/oobe.js
index 0afd05628f4a1af3271f3246f54d4155df1d88cf..7309143e0b96b765d1db27bf780f968f4ca79af8 100644
--- a/chrome/browser/resources/chromeos/login/oobe.js
+++ b/chrome/browser/resources/chromeos/login/oobe.js
@@ -293,7 +293,7 @@ cr.define('cr.ui', function() {
$('cancel-add-user-button').addEventListener('click', function(e) {
this.hidden = true;
$('add-user-button').hidden = false;
- Oobe.showScreen({id: 'account-picker'});
+ Oobe.showScreen({id: SCREEN_ACCOUNT_PICKER});
});
document.addEventListener('keydown', function(e) {
@@ -457,11 +457,12 @@ cr.define('cr.ui', function() {
/**
* Shows sign-in error bubble.
+ * @param {number} loginAttempts Number of login attemps tried.
* @param {string} message Error message to show.
* @param {string} link Text to use for help link.
* @param {number} helpId Help topic Id associated with help link.
*/
- Oobe.showSignInError = function(message, link, helpId) {
+ Oobe.showSignInError = function(loginAttempts, message, link, helpId) {
var currentScreenId = Oobe.getInstance().currentScreen.id;
var anchor = undefined;
if (currentScreenId == SCREEN_SIGNIN) {
@@ -471,6 +472,12 @@ cr.define('cr.ui', function() {
$('signin').reset(true);
} else if (currentScreenId == SCREEN_ACCOUNT_PICKER &&
$('pod-row').activated) {
+ const MAX_LOGIN_ATTEMMPTS_IN_POD = 3;
+ if (loginAttempts > MAX_LOGIN_ATTEMMPTS_IN_POD) {
+ Oobe.showSigninUI($('pod-row').activated.user.emailAddress);
+ return;
+ }
+
anchor = $('pod-row').activated.mainInput;
}
if (!anchor) {
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe.css ('k') | chrome/browser/resources/chromeos/login/screen_account_picker.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698