chrome/browser/renderer_host/render_widget_host_view_mac.mm - Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix corner case with removal of renderer to child id mappings. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view_win.cc » ('j') | content/browser/accessibility/browser_accessibility_cocoa.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm

index 1f0b3d532e31f060d99c4cebd05e44952939c8ec..4da81f496fa548c329e4a7e369c81f22c3fe4aa6 100644

--- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1063,6 +1063,9 @@ void RenderWidgetHostViewMac::OnAccessibilityNotifications(

if (!browser_accessibility_manager_.get()) {

// Use empty document to process notifications

webkit_glue::WebAccessibility empty_document;

+ // Renderer id's always start at 1000 as determined by webkit. Boot strap

+ // our ability to reuse BrowserAccessibility instances.

+ empty_document.id = 1000;

dmazzoni 2011/08/02 06:19:35 Could you move this to a common place, so it isn't

empty_document.role = WebAccessibility::ROLE_WEB_AREA;

empty_document.state = 0;

browser_accessibility_manager_.reset(

« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view_win.cc » ('j') | content/browser/accessibility/browser_accessibility_cocoa.h » ('J')