Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2267)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_win.cc

Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix corner case with removal of renderer to child id mappings. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view_win.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_win.cc b/chrome/browser/renderer_host/render_widget_host_view_win.cc
index a675936c059c946ef883f58e4f121f8d1bcf7b0b..bc3ec34225691b9c279fccc040505e7b1832fd3e 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_win.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_win.cc
@@ -1444,7 +1444,10 @@ void RenderWidgetHostViewWin::OnAccessibilityNotifications(
if (!browser_accessibility_manager_.get()) {
// Use empty document to process notifications
webkit_glue::WebAccessibility empty_document;
- empty_document.role = WebAccessibility::ROLE_DOCUMENT;
+ // Renderer id's always start at 1000 as determined by webkit. Boot strap
+ // our ability to reuse BrowserAccessibility instances.
+ empty_document.id = 1000;
+ empty_document.role = WebAccessibility::ROLE_WEB_AREA;
empty_document.state = 0;
browser_accessibility_manager_.reset(
BrowserAccessibilityManager::Create(m_hWnd, empty_document, this));
@@ -1626,7 +1629,8 @@ IAccessible* RenderWidgetHostViewWin::GetIAccessible() {
if (!browser_accessibility_manager_.get()) {
// Return busy document tree while renderer accessibility tree loads.
webkit_glue::WebAccessibility loading_tree;
- loading_tree.role = WebAccessibility::ROLE_DOCUMENT;
+ loading_tree.id = 1000;
+ loading_tree.role = WebAccessibility::ROLE_WEB_AREA;
loading_tree.state = (1 << WebAccessibility::STATE_BUSY);
browser_accessibility_manager_.reset(
BrowserAccessibilityManager::Create(m_hWnd, loading_tree, this));

Powered by Google App Engine
This is Rietveld 408576698