content/browser/accessibility/browser_accessibility_cocoa.h - Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.h

Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix corner case with removal of renderer to child id mappings. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/render_widget_host_view_mac.mm ('K') | « chrome/browser/renderer_host/render_widget_host_view_win.cc ('k') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.h

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.h b/content/browser/accessibility/browser_accessibility_cocoa.h

index ab4044f3ee0e02f044e9bf95db79f4c6d3b3f605..bf1134d4b3a694d724c61df7e36a6e9f5b5b41a8 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.h

+++ b/content/browser/accessibility/browser_accessibility_cocoa.h

@@ -16,9 +16,7 @@

// object. The renderer converts webkit's accessibility tree into a

// WebAccessibility tree and passes it to the browser process over IPC.

// This class converts it into a format Cocoa can query.

-// Inheriting from NSView rather than NSObject as clients cannot add

dmazzoni 2011/08/02 06:19:35 Does this matter? Are we losing anything by inheri

David Tseng 2011/08/02 21:30:57 No; with the unique id private API's we no longer

-// observers to pure NSObject derived classes.

-@interface BrowserAccessibilityCocoa : NSView {

+@interface BrowserAccessibilityCocoa : NSObject {

@private

BrowserAccessibility* browserAccessibility_;

scoped_nsobject<NSMutableArray> children_;