Plumb the title direction up to the renderer host

Plumb the title direction up to the renderer host

We need the title direction to properly display titles in Chrome UI.

Previously I tried just modifying the title when we get it from
WebKit to include directionality overrides, but the extensions API 
needs the underlying title without direction markers.

This change plumbs the title direction up to RenderViewHostDelegate.
A further patch will make use of it from there.

BUG=27094
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95007

[Evan Martin, 2011-08-01 19:39:23]

jam for content approval

[Evan Martin, 2011-08-01 21:02:04]

ping

[brettw, 2011-08-01 21:40:02]

LGTM

http://codereview.chromium.org/7453050/diff/3004/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7453050/diff/3004/content/renderer/render_view...
content/renderer/render_view.cc:1188: string16 shortened_title = title.substr(0,
content::kMaxTitleChars);
Personally, I'd remove the blank line after this, but whatever.

[jam, 2011-08-01 22:35:01]

lgtm, sorry for the delay

[jeremy, 2011-08-02 09:34:37]

LGTM with review comments fixed.

http://codereview.chromium.org/7453050/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/7453050/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:72: return
base::i18n::LEFT_TO_RIGHT;
I think you mean RIGHT_TO_LEFT

http://codereview.chromium.org/7453050/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.h (right):

http://codereview.chromium.org/7453050/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.h:416: WebKit::WebTextDirection
title_direction);
nit: Style here seems to be one parameter per line.

http://codereview.chromium.org/7453050/diff/6001/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7453050/diff/6001/content/renderer/render_view...
content/renderer/render_view.cc:1183: WebTextDirection title_direction) {
nit: one param per line.

http://codereview.chromium.org/7453050/diff/6001/content/renderer/render_view...
content/renderer/render_view.cc:2611:
frame->view()->mainFrame()->dataSource()->pageTitleDirection());
nit: how about putting frame->view()->mainFrame()->dataSource() in a temp
variable?