Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: content/browser/tab_contents/interstitial_page.cc

Issue 7453050: Plumb the title direction up to the renderer host (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/interstitial_page.cc
diff --git a/content/browser/tab_contents/interstitial_page.cc b/content/browser/tab_contents/interstitial_page.cc
index 64950fcb6796b854b6ce54571340cdb9f992e01f..48bbb44f10836eee70d235d6dde30dfd28ae3cd2 100644
--- a/content/browser/tab_contents/interstitial_page.cc
+++ b/content/browser/tab_contents/interstitial_page.cc
@@ -375,7 +375,8 @@ void InterstitialPage::DidNavigate(
void InterstitialPage::UpdateTitle(RenderViewHost* render_view_host,
int32 page_id,
- const string16& title) {
+ const string16& title,
+ base::i18n::TextDirection title_direction) {
DCHECK(render_view_host == render_view_host_);
NavigationEntry* entry = tab_->controller().GetActiveEntry();
if (!entry) {
@@ -397,6 +398,8 @@ void InterstitialPage::UpdateTitle(RenderViewHost* render_view_host,
original_tab_title_ = entry->title();
should_revert_tab_title_ = true;
}
+ // TODO(evan): make use of title_direction.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
entry->set_title(title);
tab_->NotifyNavigationStateChanged(TabContents::INVALIDATE_TITLE);
}

Powered by Google App Engine
This is Rietveld 408576698