Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2264)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 7453050: Plumb the title direction up to the renderer host (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index 4b7c5eba1cae1aadaf82391e2982c0a70e903c6c..19357aa3db8005f7a318c0914cf75975cc110a16 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -1494,7 +1494,8 @@ void TabContents::UpdateState(RenderViewHost* rvh,
void TabContents::UpdateTitle(RenderViewHost* rvh,
int32 page_id,
- const string16& title) {
+ const string16& title,
+ base::i18n::TextDirection title_direction) {
// If we have a title, that's a pretty good indication that we've started
// getting useful data.
SetNotWaitingForResponse();
@@ -1503,6 +1504,8 @@ void TabContents::UpdateTitle(RenderViewHost* rvh,
NavigationEntry* entry = controller_.GetEntryWithPageID(rvh->site_instance(),
page_id);
+ // TODO(evan): make use of title_direction.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
if (!UpdateTitleForEntry(entry, title))
return;

Powered by Google App Engine
This is Rietveld 408576698