Binding Graphics3D with Instance and OpenGLES2 interface.

Binding Graphics3D with Instance and OpenGLES2 interface.
BUG=86370, 78087
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93086

[piman, 2011-07-18 23:04:19]

1 nit, but lgtm otherwise.

http://codereview.chromium.org/7409003/diff/1/gpu/command_buffer/build_gles2_...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

http://codereview.chromium.org/7409003/diff/1/gpu/command_buffer/build_gles2_...
gpu/command_buffer/build_gles2_cmd_buffer.py:5749: file.Write("  else {\n")
Merge 2 lines: '} else {' is the right style.

[brettw, 2011-07-18 23:09:51]

LGTM, I didn't check the details of the script and gles2_impl stuff, since
Antoine knows more about that than I do.

http://codereview.chromium.org/7409003/diff/1/ppapi/thunk/ppb_context_3d_api.h
File ppapi/thunk/ppb_context_3d_api.h (right):

http://codereview.chromium.org/7409003/diff/1/ppapi/thunk/ppb_context_3d_api....
ppapi/thunk/ppb_context_3d_api.h:15: }  // namespace gles2.
Namespace endings are the only comments that don't get periods. Just because. :)

http://codereview.chromium.org/7409003/diff/1/webkit/plugins/ppapi/ppapi_plug...
File webkit/plugins/ppapi/ppapi_plugin_instance.h (right):

http://codereview.chromium.org/7409003/diff/1/webkit/plugins/ppapi/ppapi_plug...
webkit/plugins/ppapi/ppapi_plugin_instance.h:338: PPB_Graphics3D_Impl*
bound_graphics_3d() const;
Can you call this GetBoundsGraphics3D? The other ones are wrong and should be
updated. You don't have to update the other ones if you don't want, but I'd
rather not add more wrong ones.

[alokp, 2011-07-19 16:32:59]

http://codereview.chromium.org/7409003/diff/1/gpu/command_buffer/build_gles2_...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

http://codereview.chromium.org/7409003/diff/1/gpu/command_buffer/build_gles2_...
gpu/command_buffer/build_gles2_cmd_buffer.py:5749: file.Write("  else {\n")
On 2011/07/18 23:04:19, piman wrote:
> Merge 2 lines: '} else {' is the right style.

Done.

http://codereview.chromium.org/7409003/diff/1/ppapi/thunk/ppb_context_3d_api.h
File ppapi/thunk/ppb_context_3d_api.h (right):

http://codereview.chromium.org/7409003/diff/1/ppapi/thunk/ppb_context_3d_api....
ppapi/thunk/ppb_context_3d_api.h:15: }  // namespace gles2.
On 2011/07/18 23:09:51, brettw wrote:
> Namespace endings are the only comments that don't get periods. Just because.
:)

Done.

http://codereview.chromium.org/7409003/diff/1/webkit/plugins/ppapi/ppapi_plug...
File webkit/plugins/ppapi/ppapi_plugin_instance.h (right):

http://codereview.chromium.org/7409003/diff/1/webkit/plugins/ppapi/ppapi_plug...
webkit/plugins/ppapi/ppapi_plugin_instance.h:338: PPB_Graphics3D_Impl*
bound_graphics_3d() const;
On 2011/07/18 23:09:51, brettw wrote:
> Can you call this GetBoundsGraphics3D? The other ones are wrong and should be
> updated. You don't have to update the other ones if you don't want, but I'd
> rather not add more wrong ones.

DONE. I replaced all the wrong ones.

[piman, 2011-07-19 16:39:23]

LGTM, thanks !

[commit-bot: I haz the power, 2011-07-19 20:26:20]

Presubmit check for 7409003-11005 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  gpu/command_buffer/build_gles2_cmd_buffer.py, line 5732, 96 chars \
  gpu/command_buffer/build_gles2_cmd_buffer.py, line 5734, 94 chars \
  gpu/command_buffer/build_gles2_cmd_buffer.py, line 5736, 96 chars

Presubmit checks took 1.1s to calculate.