Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8880)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/web_applications/web_app.cc

Issue 7386002: Rename CommandLine::GetCommandLineString(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/about_flags_unittest.cc ('K') | « chrome/browser/ui/webui/options/options_ui.cc ('k') | chrome/common/service_process_util_linux.cc » ('j') | chrome/installer/util/product.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app.cc
diff --git a/chrome/browser/web_applications/web_app.cc b/chrome/browser/web_applications/web_app.cc
index cbae635dbf27a5fb547c30d9c321f64089e2b172..30b4011ebe58977a3dae2321bbf4dfeeb3b028f3 100644
--- a/chrome/browser/web_applications/web_app.cc
+++ b/chrome/browser/web_applications/web_app.cc
@@ -330,11 +330,7 @@ bool CreateShortcutTask::CreateShortcut() {
CommandLine cmd_line =
ShellIntegration::CommandLineArgsForLauncher(shortcut_info_.url,
shortcut_info_.extension_id);
- // TODO(evan): we rely on the fact that command_line_string() is
- // properly quoted for a Windows command line. The method on
- // CommandLine should probably be renamed to better reflect that
- // fact.
Evan Martin 2011/07/15 21:05:16 This TODO still exists, then.
msw 2011/07/18 20:59:33 Done.
- std::wstring wide_switches(cmd_line.command_line_string());
+ std::wstring wide_switches(cmd_line.GetCommandLineString());
// Sanitize description
if (shortcut_info_.description.length() >= MAX_PATH)
« chrome/browser/about_flags_unittest.cc ('K') | « chrome/browser/ui/webui/options/options_ui.cc ('k') | chrome/common/service_process_util_linux.cc » ('j') | chrome/installer/util/product.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698