chrome/browser/about_flags_unittest.cc - Issue 7386002: Rename CommandLine::GetCommandLineString().

Unified Diff: chrome/browser/about_flags_unittest.cc

Issue 7386002: Rename CommandLine::GetCommandLineString(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/about_flags_unittest.cc

diff --git a/chrome/browser/about_flags_unittest.cc b/chrome/browser/about_flags_unittest.cc

index 21a85cb794b9de2566ca47204b69f8168d328e90..5ac73970c6339236a875c4d251b30395e2d82b7a 100644

--- a/chrome/browser/about_flags_unittest.cc

+++ b/chrome/browser/about_flags_unittest.cc

@@ -250,8 +250,7 @@ TEST_F(AboutFlagsTest, CheckValues) {

// Convert the flags to switches.

ConvertFlagsToSwitches(&prefs_, &command_line);

EXPECT_TRUE(command_line.HasSwitch(kSwitch1));

- EXPECT_EQ(std::string(""),

- command_line.GetSwitchValueASCII(kSwitch1));

Evan Martin 2011/07/15 20:31:32 Not that it matters, but I think the reasoning for

msw 2011/07/15 20:42:55 Good to know, I can revert that if you'd like.

msw 2011/07/18 20:59:33 Reverted.

+ EXPECT_TRUE(command_line.GetSwitchValueASCII(kSwitch1).empty());

EXPECT_TRUE(command_line.HasSwitch(kSwitch2));

EXPECT_EQ(std::string(kValueForSwitch2),

command_line.GetSwitchValueASCII(kSwitch2));

@@ -262,11 +261,11 @@ TEST_F(AboutFlagsTest, CheckValues) {

std::string("=");

#if defined(OS_WIN)

EXPECT_EQ(std::wstring::npos,

- command_line.command_line_string().find(

+ command_line.GetCommandLineString().find(

ASCIIToWide(switch1_with_equals)));

#else

EXPECT_EQ(std::string::npos,

- command_line.command_line_string().find(switch1_with_equals));

+ command_line.GetCommandLineString().find(switch1_with_equals));

#endif

// And confirm there is a '=' for switches with values.

@@ -275,11 +274,11 @@ TEST_F(AboutFlagsTest, CheckValues) {

std::string("=");

#if defined(OS_WIN)

EXPECT_NE(std::wstring::npos,

- command_line.command_line_string().find(

+ command_line.GetCommandLineString().find(

ASCIIToWide(switch2_with_equals)));

#else

EXPECT_NE(std::string::npos,

- command_line.command_line_string().find(switch2_with_equals));

+ command_line.GetCommandLineString().find(switch2_with_equals));

#endif

// And it should persist

« no previous file with comments | « chrome/app/chrome_main.cc ('k') | chrome/browser/automation/testing_automation_provider.cc » ('j') | chrome/browser/web_applications/web_app.cc » ('J')