Rename CommandLine::GetCommandLineString().

chrome/installer/util/product.cc

Index: chrome/installer/util/product.cc
diff --git a/chrome/installer/util/product.cc b/chrome/installer/util/product.cc
index 6d3d44d39ba77ee50c3ef4eeba4b309cb2425a8a..fdbf82d53e2dadfd0f43af3c243008a0180573bc 100644
--- a/chrome/installer/util/product.cc
+++ b/chrome/installer/util/product.cc
@@ -80,15 +80,15 @@ bool Product::LaunchChromeAndWait(const FilePath& application_path,
   bool success = false;
   STARTUPINFOW si = { sizeof(si) };
   PROCESS_INFORMATION pi = {0};
-  // Cast away constness of the command_line_string() since CreateProcess
+  // Cast away constness of the GetCommandLineString() since CreateProcess
   // might modify the string (insert \0 to separate the program from the
   // arguments).  Since we're not using the cmd variable beyond this point
   // we don't care.

[Evan Martin, 2011/07/15 21:05:16]

This feels pretty dangerous to me; for example, the PLOG() below will do the
wrong thing depending on whether we're reusing a member or not.  Sigh.

[msw, 2011/07/18 20:59:33]

Yeah, this isn't a good practice. I changed this and base/process_util_win.cc to
follow the pattern used in sandbox/src/Wow64.cc; please consider.

   if (!::CreateProcess(cmd.GetProgram().value().c_str(),
-                       const_cast<wchar_t*>(cmd.command_line_string().c_str()),
+                       const_cast<wchar_t*>(cmd.GetCommandLineString().c_str()),
                        NULL, NULL, FALSE, CREATE_NO_WINDOW, NULL, NULL,
                        &si, &pi)) {
-    PLOG(ERROR) << "Failed to launch: " << cmd.command_line_string();
+    PLOG(ERROR) << "Failed to launch: " << cmd.GetCommandLineString();
   } else {
     ::CloseHandle(pi.hThread);