Issue 7357: Makes the following changes to the bookmark bar context menu:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7357: Makes the following changes to the bookmark bar context menu:... (Closed)

Created:
12 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes the following changes to the bookmark bar context menu: . Nukes the open menu item. . Adds open incognito and for folders open all incognito. BUG=144 TEST=Fully test the context menu of bookmark folders/urls. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3464

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -93 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	2 chunks	+5 lines, -2 lines	2 comments	Download
M	chrome/browser/bookmark_bar_context_menu_controller.h	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/bookmark_bar_context_menu_controller.cc	View	1	11 chunks	+49 lines, -47 lines	0 comments	Download
M	chrome/browser/bookmark_bar_context_menu_controller_test.cc	View	1	2 chunks	+26 lines, -29 lines	0 comments	Download
M	chrome/test/testing_profile.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/test/testing_profile.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

12 years, 2 months ago (2008-10-15 23:01:24 UTC) #2

LGTM with spelling changes:

http://codereview.chromium.org/7357/diff/15/203
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7357/diff/15/203#newcode2111
Line 2111: <message name="IDS_BOOMARK_BAR_OPEN_INCOGNITO" desc="Menu description
for openning bookmark in incognito window">
"openning" > "opening"

http://codereview.chromium.org/7357/diff/15/203#newcode2132
Line 2132: <message name="IDS_BOOMARK_BAR_OPEN_ALL_INCOGNITO" desc="Menu
description for openning all urls in a bookmark folder in an incognito window">
"openning" > "opening"

Expand Messages | Collapse Messages