Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 7352014: Revert "Add COMPONENT_BUILD global define. " (Closed)

Created:
9 years, 5 months ago by yurys
Modified:
9 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert "Add COMPONENT_BUILD global define. " The change broke compilation on Linux Builder (dbg)(shared): http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio TBR=darin BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -67 lines) Patch
M base/at_exit.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 3 chunks +13 lines, -36 lines 0 comments Download
M base/base_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/debug_on_start_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/logging.h View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/crypto.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M crypto/crypto_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/net_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/ssl_false_start_blacklist.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/net.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
M sandbox/sandbox.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle_dummy.cc View 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
9 years, 5 months ago (2011-07-13 08:18:44 UTC) #1
darin (slow to review)
9 years, 5 months ago (2011-07-13 08:39:03 UTC) #2
LGTM

Thanks for cleaning this up.
-Darin

On Wed, Jul 13, 2011 at 1:18 AM, <yurys@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Revert "Add COMPONENT_BUILD global define. "
>
> The change broke compilation on Linux Builder (dbg)(shared):
> http://build.chromium.org/p/**chromium/builders/Linux%**
>
20Builder%20%28dbg%29%**28shared%29/builds/3365/steps/**compile/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio>
>
> TBR=darin
> BUG=None
> TEST=None
>
>
> Please review this at
http://codereview.chromium.**org/7352014/<http://codereview.chromium.org/7352...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M base/at_exit.cc
>  M base/base.gypi
>  M base/base_api.h
>  M base/debug/debug_on_start_win.**h
>  M base/logging.h
>  M build/common.gypi
>  M chrome/chrome.gyp
>  M chrome/chrome_dll.gypi
>  M chrome/chrome_exe.gypi
>  M crypto/crypto.gyp
>  M crypto/crypto_api.h
>  M ipc/ipc.gypi
>  M net/base/net_api.h
>  M net/base/ssl_false_start_**blacklist.h
>  M net/net.gyp
>  M sandbox/sandbox.gyp
>  M ui/base/resource/resource_**bundle_dummy.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698