Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: net/net.gyp

Issue 7352014: Revert "Add COMPONENT_BUILD global define. " (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/ssl_false_start_blacklist.h ('k') | sandbox/sandbox.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index 31afc1747f8095f28be821bc1bd7798e4237c12f..1eb0a8d24b6507decf7b46621d5cef4b83df9780 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -822,8 +822,27 @@
],
[ 'component == "shared_library"', {
'defines': [
+ 'NET_DLL',
'NET_IMPLEMENTATION',
],
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'NET_DLL',
+ ],
+ },
+ 'conditions': [
+ [ 'OS == "win"', {
+ 'msvs_disabled_warnings': [
+ # class 'std::xx' needs to have dll-interface.
+ 4251,
+ ],
+ 'direct_dependent_settings': {
+ 'msvs_disabled_warnings': [
+ 4251,
+ ],
+ },
+ }],
+ ],
}],
[ 'OS == "mac"', {
'dependencies': [
« no previous file with comments | « net/base/ssl_false_start_blacklist.h ('k') | sandbox/sandbox.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698