build/common.gypi - Issue 7352014: Revert "Add COMPONENT_BUILD global define. "

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 7352014: Revert "Add COMPONENT_BUILD global define. " (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 9b67d7367c1a91a439190601553bebfa009659a8..4ed9fefe2b6225867bae78a6007bcd1a7c33565e 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -694,9 +694,6 @@

}, { # else: branding!="Chrome"

'defines': ['CHROMIUM_BUILD'],

}],

- ['component=="shared_library"', {

- 'defines': ['COMPONENT_BUILD'],

- }],

['toolkit_views==1', {

'defines': ['TOOLKIT_VIEWS=1'],

}],

@@ -925,11 +922,6 @@

}],

- ['OS=="win" and component=="shared_library"', {

- 'msvs_disabled_warnings': [

- 4251, # class 'std::xx' needs to have dll-interface.

- ],

- }],

['chromeos!=1', {

'sources/': [ ['exclude', '_chromeos\\.(h|cc)$'] ]

}],

« no previous file with comments | « base/logging.h ('k') | chrome/chrome.gyp » ('j') | no next file with comments »