Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 7330028: Merge 90383 - Merge 89600 - Treat ERR_CONNECTION_CLOSED as a succesful download. (Closed)

Created:
9 years, 5 months ago by laforge
Modified:
9 years, 5 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 90383 - Merge 89600 - Treat ERR_CONNECTION_CLOSED as a succesful download. Some servers will send a Content-Length which exceeds the number of bytes sent in the message body. Although this violates the RFC spec, other major browsers permit it and treat a download as complete in that case. Chrome did as well prior to M12, and now some users are unable to access the item that they downloaded. BUG=85549 TEST=Go to server which advertises larger Content-Length than number of bytes sent, confirm that the download is no longer reported as interrupted. Review URL: http://codereview.chromium.org/7203004 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/7251001 TBR=cbentzel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/download/download_manager.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
laforge
9 years, 5 months ago (2011-07-08 23:46:30 UTC) #1
Randy Smith (Not in Mondays)
Anthony: Chris is out on vacation. You have my LGTM if you want it, but ...
9 years, 5 months ago (2011-07-09 01:26:49 UTC) #2
laforge
9 years, 5 months ago (2011-07-09 03:49:11 UTC) #3
This is a special branch due to a flash 0-day release.  Just pulled it over
from the original 742 branch.

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA


On Fri, Jul 8, 2011 at 6:26 PM, <rdsmith@chromium.org> wrote:

> Anthony: Chris is out on vacation.  You have my LGTM if you want it, but
> I'm
> confused: I thought this had already been merged into MS-12 and we just
> hadn't
> published a new version since the merge?
>
>
>
>
http://codereview.chromium.**org/7330028/<http://codereview.chromium.org/7330...
>

Powered by Google App Engine
This is Rietveld 408576698