Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 7203004: Treat ERR_CONNECTION_CLOSED as a succesful download. (Closed)

Created:
9 years, 6 months ago by cbentzel
Modified:
9 years, 6 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Treat ERR_CONNECTION_CLOSED as a succesful download. Some servers will send a Content-Length which exceeds the number of bytes sent in the message body. Although this violates the RFC spec, other major browsers permit it and treat a download as complete in that case. Chrome did as well prior to M12, and now some users are unable to access the item that they downloaded. BUG=85549 TEST=Go to server which advertises larger Content-Length than number of bytes sent, confirm that the download is no longer reported as interrupted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/download/download_manager.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
cbentzel
I ran both browser_tests and unit_tests locally with --gtest_filter="*Download*" and found nothing which failed. This ...
9 years, 6 months ago (2011-06-17 18:45:24 UTC) #1
ahendrickson
LGTM. On 2011/06/17 18:45:24, cbentzel wrote: > I ran both browser_tests and unit_tests locally with ...
9 years, 6 months ago (2011-06-17 18:54:24 UTC) #2
commit-bot: I haz the power
9 years, 6 months ago (2011-06-18 11:54:21 UTC) #3
Change committed as 89600

Powered by Google App Engine
This is Rietveld 408576698