Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 7251001: Merge 89600 - Treat ERR_CONNECTION_CLOSED as a succesful download. (Closed)

Created:
9 years, 6 months ago by cbentzel
Modified:
9 years, 6 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 89600 - Treat ERR_CONNECTION_CLOSED as a succesful download. Some servers will send a Content-Length which exceeds the number of bytes sent in the message body. Although this violates the RFC spec, other major browsers permit it and treat a download as complete in that case. Chrome did as well prior to M12, and now some users are unable to access the item that they downloaded. BUG=85549 TEST=Go to server which advertises larger Content-Length than number of bytes sent, confirm that the download is no longer reported as interrupted. Review URL: http://codereview.chromium.org/7203004 TBR=cbentzel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/download/download_manager.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
cbentzel
9 years, 6 months ago (2011-06-24 17:47:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698