Add some useful Chrome URLs to chrome://chrome-urls/.

Add some useful Chrome URLs to chrome://chrome-urls/.

BUG=73926
TEST=New URLS in chrome://chrome-urls/.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92278

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92320

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92426

[msw, 2011-07-07 23:26:49]

PTAL, thanks. Jeff specifically called out about:blank in the bug. Perhaps you
have a better idea of how to include/present that link.

[Peter Kasting, 2011-07-12 23:37:28]

LGTM

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
File chrome/browser/browser_about_handler.cc (left):

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
chrome/browser/browser_about_handler.cc:118: chrome::kChromeUIGpuInternalsHost,
Are these two "internals" URLs deprecated versions of the "non-internals"
versions you've included?

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
chrome/browser/browser_about_handler.cc:419: html += "<li><a href='" +
about_blank + "/'>" + about_blank + "</a></li>\n";
I don't think about:blank is that useful, it just looked odd that we had about:
URLs and it wasn't listed.

Now that the URLs are all chrome:// URLs, I think it's fine (and looks less
weird) to just leave it out.

[msw, 2011-07-13 00:11:08]

Done. Landing.

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
File chrome/browser/browser_about_handler.cc (left):

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
chrome/browser/browser_about_handler.cc:118: chrome::kChromeUIGpuInternalsHost,
On 2011/07/12 23:37:28, Peter Kasting wrote:
> Are these two "internals" URLs deprecated versions of the "non-internals"
> versions you've included?

Hmm, I guess the internals URLs are meant to supersede their non-internals
counterparts (looking at crrev.com/71435 and crrev.com/69211). The two pairs
navigate to the same new DOMUI pages, but I'll revert to the internals URLs,
since "-internals" seems intentional for whatever reason.

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/7329004/diff/2001/chrome/browser/browser_about...
chrome/browser/browser_about_handler.cc:419: html += "<li><a href='" +
about_blank + "/'>" + about_blank + "</a></li>\n";
On 2011/07/12 23:37:28, Peter Kasting wrote:
> I don't think about:blank is that useful, it just looked odd that we had
about:
> URLs and it wasn't listed.
> 
> Now that the URLs are all chrome:// URLs, I think it's fine (and looks less
> weird) to just leave it out.

Done.

[msw, 2011-07-13 19:03:59]

FYI, I needed to update BuiltinProviderTest. You can take another look if you'd
like.