Add some useful Chrome URLs to chrome://chrome-urls/.

chrome/browser/browser_about_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_about_handler.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 91 matching lines @@
 }
 #endif
 
 namespace {
 
 // Add paths here to be included in chrome://chrome-urls/.
 // These paths will also be suggested by BuiltinProvider.
 const char* const kChromePaths[] = {
   chrome::kChromeUIAppCacheInternalsHost,
   chrome::kChromeUIBlobInternalsHost,
+  chrome::kChromeUIBookmarksHost,
+  chrome::kChromeUICacheHost,
   chrome::kChromeUIChromeURLsHost,
   chrome::kChromeUICrashesHost,
   chrome::kChromeUICreditsHost,
   chrome::kChromeUIDNSHost,
+  chrome::kChromeUIDownloadsHost,
+  chrome::kChromeUIExtensionsHost,
   chrome::kChromeUIFlagsHost,
   chrome::kChromeUIFlashHost,
-  chrome::kChromeUIGpuInternalsHost,

[Peter Kasting, 2011/07/12 23:37:28]

Are these two "internals" URLs deprecated versions of the "non-internals"
versions you've included?

[msw, 2011/07/13 00:11:08]

Hmm, I guess the internals URLs are meant to supersede their non-internals
counterparts (looking at crrev.com/71435 and crrev.com/69211). The two pairs
navigate to the same new DOMUI pages, but I'll revert to the internals URLs,
since "-internals" seems intentional for whatever reason.

+  chrome::kChromeUIGpuHost,
   chrome::kChromeUIHistogramsHost,
+  chrome::kChromeUIHistoryHost,
+  chrome::kChromeUIIPCHost,
   chrome::kChromeUIMemoryHost,
   chrome::kChromeUINetInternalsHost,
   chrome::kChromeUINetworkViewCacheHost,
+  chrome::kChromeUINewTabHost,
   chrome::kChromeUIPluginsHost,
+  chrome::kChromeUIPrintHost,
+  chrome::kChromeUIQuotaInternalsHost,
+  chrome::kChromeUISessionsHost,
   chrome::kChromeUISettingsHost,
   chrome::kChromeUIStatsHost,
-  chrome::kChromeUISyncInternalsHost,
+  chrome::kChromeUISyncHost,
+  chrome::kChromeUITasksHost,
   chrome::kChromeUITCMallocHost,
   chrome::kChromeUITermsHost,
   chrome::kChromeUIVersionHost,
+  chrome::kChromeUIWorkersHost,
 #ifdef TRACK_ALL_TASK_OBJECTS
   chrome::kChromeUITasksHost,
 #endif
 #if defined(OS_WIN)
   chrome::kChromeUIConflictsHost,
 #endif
 #if defined(OS_LINUX)
+  chrome::kChromeUILinuxProxyConfigHost,
   chrome::kChromeUISandboxHost,
 #endif
 #if defined(OS_CHROMEOS)
+  chrome::kChromeUIActiveDownloadsHost,
+  chrome::kChromeUIChooseMobileNetworkHost,
+  chrome::kChromeUICryptohomeHost,
+  chrome::kChromeUIImageBurnerHost,
+  chrome::kChromeUIKeyboardOverlayHost,
+  chrome::kChromeUILoginHost,
   chrome::kChromeUINetworkHost,
-  chrome::kChromeUICryptohomeHost,
+  chrome::kChromeUIOobeHost,
   chrome::kChromeUIOSCreditsHost,
+  chrome::kChromeUIProxySettingsHost,
+  chrome::kChromeUISystemInfoHost,
 #endif
 };
 
 // Debug paths, presented without links in chrome://about.
 // These paths will not be suggested by BuiltinProvider.
 const char* const kDebugChromePaths[] = {
   chrome::kChromeUICrashHost,
   chrome::kChromeUIKillHost,
   chrome::kChromeUIHangHost,
   chrome::kChromeUIShorthangHost,
@@ skipping 234 matching lines @@
 
 void AppendFooter(std::string *output) {
   output->append("</body>\n</html>\n");
 }
 
 std::string ChromeURLs() {
   std::string html;
   AppendHeader(&html, 0, "Chrome URLs");
   AppendBody(&html);
   html += "<h2>List of Chrome URLs</h2>\n<ul>\n";
+  std::string about_blank(chrome::kAboutBlankURL);
+  html += "<li><a href='" + about_blank + "/'>" + about_blank + "</a></li>\n";

[Peter Kasting, 2011/07/12 23:37:28]

I don't think about:blank is that useful, it just looked odd that we had about:
URLs and it wasn't listed.

Now that the URLs are all chrome:// URLs, I think it's fine (and looks less
weird) to just leave it out.

[msw, 2011/07/13 00:11:08]

Done.

   std::vector<std::string> paths(ChromePaths());
   for (std::vector<std::string>::const_iterator i = paths.begin();
        i != paths.end(); ++i)
     html += "<li><a href='chrome://" + *i + "/'>chrome://" + *i + "</a></li>\n";
   html += "</ul>\n<h2>For Debug</h2>\n"
       "<p>The following pages are for debugging purposes only. Because they "
       "crash or hang the renderer, they're not linked directly; you can type "
       "them into the address bar if you need them.</p>\n<ul>";
   for (size_t i = 0; i < arraysize(kDebugChromePaths); i++)
     html += "<li>chrome://" + std::string(kDebugChromePaths[i]) + "</li>\n";
@@ skipping 1066 matching lines @@
   return false;
 }
 
 std::vector<std::string> ChromePaths() {
   std::vector<std::string> paths;
   paths.reserve(arraysize(kChromePaths));
   for (size_t i = 0; i < arraysize(kChromePaths); i++)
     paths.push_back(kChromePaths[i]);
   return paths;
 }