Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: chrome/browser/autocomplete/builtin_provider_unittest.cc

Issue 7329004: Add some useful Chrome URLs to chrome://chrome-urls/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update BuiltinProviderTest. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/builtin_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/builtin_provider_unittest.cc b/chrome/browser/autocomplete/builtin_provider_unittest.cc
index fed7394d8b266b0cccb374d131155ee8161debd9..430fb33d91b3b9aaf407a107ea5329f785981adc 100644
--- a/chrome/browser/autocomplete/builtin_provider_unittest.cc
+++ b/chrome/browser/autocomplete/builtin_provider_unittest.cc
@@ -141,8 +141,8 @@ TEST_F(BuiltinProviderTest, ChromeURLs) {
// This makes assumptions about the chrome URLs listed by the BuiltinProvider.
// Currently they are derived from ChromePaths() in browser_about_handler.cc.
- const string16 kHostA = ASCIIToUTF16(chrome::kChromeUIAppCacheInternalsHost);
- const GURL kURLA = GURL(kChrome + kSeparator3 + kHostA);
+ const string16 kHostE = ASCIIToUTF16(chrome::kChromeUIExtensionsHost);
+ const GURL kURLE = GURL(kChrome + kSeparator3 + kHostE);
const string16 kHostF1 = ASCIIToUTF16(chrome::kChromeUIFlagsHost);
const string16 kHostF2 = ASCIIToUTF16(chrome::kChromeUIFlashHost);
const GURL kURLF1 = GURL(kChrome + kSeparator3 + kHostF1);
@@ -160,20 +160,20 @@ TEST_F(BuiltinProviderTest, ChromeURLs) {
{kChrome + kSeparator3 + ASCIIToUTF16("host"), 0, {}},
// Typing an about URL for a unique host should provide that full URL.
- {kAbout + kSeparator1 + kHostA.substr(0, 1), 1, {kURLA}},
- {kAbout + kSeparator2 + kHostA.substr(0, 2), 1, {kURLA}},
- {kAbout + kSeparator3 + kHostA.substr(0, kHostA.length() - 1), 1, {kURLA}},
- {kAbout + kSeparator1 + kHostA, 1, {kURLA}},
- {kAbout + kSeparator2 + kHostA, 1, {kURLA}},
- {kAbout + kSeparator3 + kHostA, 1, {kURLA}},
+ {kAbout + kSeparator1 + kHostE.substr(0, 1), 1, {kURLE}},
+ {kAbout + kSeparator2 + kHostE.substr(0, 2), 1, {kURLE}},
+ {kAbout + kSeparator3 + kHostE.substr(0, kHostE.length() - 1), 1, {kURLE}},
+ {kAbout + kSeparator1 + kHostE, 1, {kURLE}},
+ {kAbout + kSeparator2 + kHostE, 1, {kURLE}},
+ {kAbout + kSeparator3 + kHostE, 1, {kURLE}},
// Typing a chrome URL for a unique host should provide that full URL.
- {kChrome + kSeparator1 + kHostA.substr(0, 1), 1, {kURLA}},
- {kChrome + kSeparator2 + kHostA.substr(0, 2), 1, {kURLA}},
- {kChrome + kSeparator3 + kHostA.substr(0, kHostA.length() - 1), 1, {kURLA}},
- {kChrome + kSeparator1 + kHostA, 1, {kURLA}},
- {kChrome + kSeparator2 + kHostA, 1, {kURLA}},
- {kChrome + kSeparator3 + kHostA, 1, {kURLA}},
+ {kChrome + kSeparator1 + kHostE.substr(0, 1), 1, {kURLE}},
+ {kChrome + kSeparator2 + kHostE.substr(0, 2), 1, {kURLE}},
+ {kChrome + kSeparator3 + kHostE.substr(0, kHostE.length() - 1), 1, {kURLE}},
+ {kChrome + kSeparator1 + kHostE, 1, {kURLE}},
+ {kChrome + kSeparator2 + kHostE, 1, {kURLE}},
+ {kChrome + kSeparator3 + kHostE, 1, {kURLE}},
// Typing an about URL with a non-unique host should provide matching URLs.
{kAbout + kSeparator1 + kHostF1.substr(0, 1), 2, {kURLF1, kURLF2}},
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698