Split SystemAccess into TimezoneSettings, StatisticsProvider, and SyslogsProvider.

Split SystemAccess into TimezoneSettings, StatisticsProvider, and SyslogsProvider.

SystemAccess contained three separate things: timezone settings,
statistics provider, and syslogs provider. We should have them
in separate classes.

This patch touches many files but changes are mechanical. No logic
changes introduced.

BUG=none
TEST=chrome builds and try bots pass

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91971

[satorux1, 2011-07-08 03:25:10]

Steven,

This patch may look overwhelmingly large, but all changes are mechanical and no
logic changes are introduced. I hope you'll like the refacotring.

[stevenjb, 2011-07-08 22:38:09]

lgtm with nits

http://codereview.chromium.org/7324017/diff/45/chrome/browser/bug_report_util.cc
File chrome/browser/bug_report_util.cc (right):

http://codereview.chromium.org/7324017/diff/45/chrome/browser/bug_report_util...
chrome/browser/bug_report_util.cc:331: i != sys_info->end(); ++i)
nit: combine above two lines and fix indent.

http://codereview.chromium.org/7324017/diff/45/chrome/browser/chromeos/system...
File chrome/browser/chromeos/system/mock_statistics_provider.h (right):

http://codereview.chromium.org/7324017/diff/45/chrome/browser/chromeos/system...
chrome/browser/chromeos/system/mock_statistics_provider.h:14: 
Should this also be in namespace "system"?

[satorux1, 2011-07-09 06:21:27]

http://codereview.chromium.org/7324017/diff/45/chrome/browser/bug_report_util.cc
File chrome/browser/bug_report_util.cc (right):

http://codereview.chromium.org/7324017/diff/45/chrome/browser/bug_report_util...
chrome/browser/bug_report_util.cc:331: i != sys_info->end(); ++i)
On 2011/07/08 22:38:09, Steven Bennetts wrote:
> nit: combine above two lines and fix indent.

Done.

http://codereview.chromium.org/7324017/diff/45/chrome/browser/chromeos/system...
File chrome/browser/chromeos/system/mock_statistics_provider.h (right):

http://codereview.chromium.org/7324017/diff/45/chrome/browser/chromeos/system...
chrome/browser/chromeos/system/mock_statistics_provider.h:14: 
On 2011/07/08 22:38:09, Steven Bennetts wrote:
> Should this also be in namespace "system"?

Good catch! It was an oversight. Fixed.